From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH 1/2] KVM: x86 emulator: don't update vcpu state if instruction is restarted.
Date: Sun, 01 Aug 2010 12:14:40 +0300 [thread overview]
Message-ID: <4C553B00.8030100@redhat.com> (raw)
In-Reply-To: <20100801090145.GD24773@redhat.com>
On 08/01/2010 12:01 PM, Gleb Natapov wrote:
>>>
>>> It uses rip _during_ pio. And pio emulation changes rip
>>> only at the end of emulation.
>> But non-emulated pio does a skip_emulated_instruction() immediately
>> (or so the code in kvm-tpr-opt.c assumes:
>>
> Indeed, this is bug in non-emulated pio.
But userspace depends on this bug.
> But the patch does not change
> rip behaviour for emulated pio. vcpu->arch.emulate_ctxt.eip is updated
> only at the end of emulation.
That will lead to failures if the emulator is used for the kvm-tpr-opt
pio (which may happen with big real mode).
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-08-01 9:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-29 12:11 [PATCH 0/2] Speedup ins instruction emulation a little Gleb Natapov
2010-07-29 12:11 ` [PATCH 1/2] KVM: x86 emulator: don't update vcpu state if instruction is restarted Gleb Natapov
2010-07-31 17:25 ` Avi Kivity
2010-08-01 8:28 ` Gleb Natapov
2010-08-01 8:54 ` Avi Kivity
2010-08-01 9:01 ` Gleb Natapov
2010-08-01 9:14 ` Avi Kivity [this message]
2010-08-01 9:24 ` Gleb Natapov
2010-08-01 10:00 ` Avi Kivity
2010-08-01 10:53 ` Gleb Natapov
2010-08-01 12:17 ` Avi Kivity
2010-08-01 12:23 ` Gleb Natapov
2010-08-01 12:35 ` Avi Kivity
2010-08-01 13:27 ` Gleb Natapov
2010-08-02 5:04 ` Avi Kivity
2010-08-02 7:58 ` Gleb Natapov
2010-08-02 8:03 ` Avi Kivity
2010-08-02 8:17 ` Gleb Natapov
2010-08-02 8:24 ` Avi Kivity
2010-08-02 8:34 ` Gleb Natapov
2010-08-02 8:54 ` Avi Kivity
2010-08-02 9:05 ` Gleb Natapov
2010-08-02 9:08 ` Avi Kivity
2010-07-29 12:11 ` [PATCH 2/2] KVM: x86 emulator: check io permissions only once for string pio Gleb Natapov
2010-07-31 1:59 ` Marcelo Tosatti
2010-07-29 12:19 ` [PATCH 0/2] Speedup ins instruction emulation a little Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C553B00.8030100@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.