From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Date: Sun, 01 Aug 2010 23:48:24 +0000 Subject: Re: [PATCH 04/25] ata: Convert pci_table entries to PCI_VDEVICE (if Message-Id: <4C5607C8.4090708@pobox.com> List-Id: References: <201007152039.44324.PeterHuewe@gmx.de> In-Reply-To: <201007152039.44324.PeterHuewe@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Peter Huewe Cc: Kernel Janitors , Tejun Heo , Sergei Shtylyov , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org On 07/15/2010 02:39 PM, Peter Huewe wrote: > From: Peter Huewe > > This patch converts pci_table entries, where .subvendor=PCI_ANY_ID and > .subdevice=PCI_ANY_ID, .class=0 and .class_mask=0, to use the > PCI_VDEVICE macro, and thus improves readability. > > Signed-off-by: Peter Huewe > --- > drivers/ata/pata_scc.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/ata/pata_scc.c b/drivers/ata/pata_scc.c > index d9db3f8..fe36966 100644 > --- a/drivers/ata/pata_scc.c > +++ b/drivers/ata/pata_scc.c > @@ -168,8 +168,7 @@ static const unsigned long JCACTSELtbl[2][7] = { > }; > > static const struct pci_device_id scc_pci_tbl[] = { > - {PCI_VENDOR_ID_TOSHIBA_2, PCI_DEVICE_ID_TOSHIBA_SCC_ATA, > - PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0}, > + { PCI_VDEVICE(TOSHIBA_2, PCI_DEVICE_ID_TOSHIBA_SCC_ATA), 0}, > { } /* terminate list */ applied I would prefer to leave ata_piix as it is, though. It's nice and manageable :) From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 04/25] ata: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used) Date: Sun, 01 Aug 2010 19:48:24 -0400 Message-ID: <4C5607C8.4090708@pobox.com> References: <201007152039.44324.PeterHuewe@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-yx0-f174.google.com ([209.85.213.174]:37224 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752048Ab0HAXs1 (ORCPT ); Sun, 1 Aug 2010 19:48:27 -0400 In-Reply-To: <201007152039.44324.PeterHuewe@gmx.de> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Peter Huewe Cc: Kernel Janitors , Tejun Heo , Sergei Shtylyov , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org On 07/15/2010 02:39 PM, Peter Huewe wrote: > From: Peter Huewe > > This patch converts pci_table entries, where .subvendor=PCI_ANY_ID and > .subdevice=PCI_ANY_ID, .class=0 and .class_mask=0, to use the > PCI_VDEVICE macro, and thus improves readability. > > Signed-off-by: Peter Huewe > --- > drivers/ata/pata_scc.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/ata/pata_scc.c b/drivers/ata/pata_scc.c > index d9db3f8..fe36966 100644 > --- a/drivers/ata/pata_scc.c > +++ b/drivers/ata/pata_scc.c > @@ -168,8 +168,7 @@ static const unsigned long JCACTSELtbl[2][7] = { > }; > > static const struct pci_device_id scc_pci_tbl[] = { > - {PCI_VENDOR_ID_TOSHIBA_2, PCI_DEVICE_ID_TOSHIBA_SCC_ATA, > - PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0}, > + { PCI_VDEVICE(TOSHIBA_2, PCI_DEVICE_ID_TOSHIBA_SCC_ATA), 0}, > { } /* terminate list */ applied I would prefer to leave ata_piix as it is, though. It's nice and manageable :)