Re: [PATCH v5] cfg80211: Add nl80211 antenna configuration

[Felix Fietkau <nbd@openwrt.org>]

On 2010-08-02 1:01 PM, Johannes Berg wrote:
> On Mon, 2010-08-02 at 12:47 +0200, Felix Fietkau wrote:
> 
>> Legacy hardware  => run time changes possible (actually optional)
>> 802.11n hardware => need to bring down the interface before changing
>>                     the antenna settings
> 
> I think I'd prefer if all hw just required the device to be stopped.
> Otherwise things either become awkward when you have, say. software
> diversity control, or they become unpredictable quite, no?
If the driver does something like that, then the antenna control
callback should reset that state as well. But then again, I don't mind
if legacy hw requires the interface to be down as well.

- Felix