All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Petlund <apetlund@simula.no>
To: Josh Hunt <johunt@akamai.com>
Cc: davem@davemloft.net, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
	kaber@trash.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, juhlenko@akamai.com
Subject: Re: [PATCH] net: Add getsockopt support for TCP thin-streams
Date: Mon, 02 Aug 2010 13:46:32 +0200	[thread overview]
Message-ID: <4C56B018.8030309@simula.no> (raw)
In-Reply-To: <1280533775-7700-1-git-send-email-johunt@akamai.com>

On 07/31/2010 01:49 AM, Josh Hunt wrote:
> Initial TCP thin-stream commit did not add getsockopt support for the new
> socket options: TCP_THIN_LINEAR_TIMEOUTS and TCP_THIN_DUPACK. This adds support
> for them.
> 
> Signed-off-by: Josh Hunt <johunt@akamai.com>
> ---
>  net/ipv4/tcp.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
> index 65afeae..3ed3525 100644
> --- a/net/ipv4/tcp.c
> +++ b/net/ipv4/tcp.c
> @@ -2591,6 +2591,12 @@ static int do_tcp_getsockopt(struct sock *sk, int level,
>  			return -EFAULT;
>  		return 0;
>  	}
> +	case TCP_THIN_LINEAR_TIMEOUTS:
> +		val = tp->thin_lto;
> +		break;
> +	case TCP_THIN_DUPACK:
> +		val = tp->thin_dupack;
> +		break;
>  	default:
>  		return -ENOPROTOOPT;
>  	}

Thanks for noticing and fixing this :)

Tested-by: Andreas Petlund <apetlund@simula.no>
Acked-by: Andreas Petlund <apetlund@simula.no>

-Andreas

  reply	other threads:[~2010-08-02 12:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-30 23:49 [PATCH] net: Add getsockopt support for TCP thin-streams Josh Hunt
2010-08-02 11:46 ` Andreas Petlund [this message]
2010-08-03  0:25   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C56B018.8030309@simula.no \
    --to=apetlund@simula.no \
    --cc=davem@davemloft.net \
    --cc=jmorris@namei.org \
    --cc=johunt@akamai.com \
    --cc=juhlenko@akamai.com \
    --cc=kaber@trash.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.