From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH] nf: make skb_make_writable() return bool Date: Mon, 02 Aug 2010 17:45:44 +0200 Message-ID: <4C56E828.9040404@trash.net> References: <1280559384-25197-1-git-send-email-xiaosuo@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , netfilter-devel@vger.kernel.org, netdev@vger.kernel.org To: Changli Gao Return-path: Received: from stinky.trash.net ([213.144.137.162]:62456 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752043Ab0HBPpo (ORCPT ); Mon, 2 Aug 2010 11:45:44 -0400 In-Reply-To: <1280559384-25197-1-git-send-email-xiaosuo@gmail.com> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On 31.07.2010 08:56, Changli Gao wrote: > Signed-off-by: Changli Gao > ---- > -int skb_make_writable(struct sk_buff *skb, unsigned int writable_len) > +bool skb_make_writable(struct sk_buff *skb, unsigned int writable_len) You can change things like this when making actual changes to the code, but this is just useless noise in the changelogs and makes it harder to locate real changes in the history.