From: Avi Kivity <avi@redhat.com>
To: Shirley Ma <mashirle@us.ibm.com>
Cc: xiaohui.xin@intel.com, netdev@vger.kernel.org,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
mst@redhat.com, mingo@elte.hu, davem@davemloft.net,
herbert@gondor.hengli.com.au, jdike@linux.intel.com
Subject: Re: [RFC PATCH v8 00/16] Provide a zero-copy method on KVM virtio-net.
Date: Mon, 02 Aug 2010 19:32:24 +0300 [thread overview]
Message-ID: <4C56F318.7030409@redhat.com> (raw)
In-Reply-To: <1280766319.22830.24.camel@localhost.localdomain>
On 08/02/2010 07:25 PM, Shirley Ma wrote:
> On Mon, 2010-08-02 at 19:11 +0300, Avi Kivity wrote:
>> I don't understand this. gup_fast() only calls gup() if the page is
>> swapped out or read-only.
> Oh, I used the page as read-only on xmit path. Should I use write
> instead?
No, for xmit getting the page as read only is fine.
I was inaccurate, gup_fast() performs as follows:
- if .write = 1, gup_fast() will be fast if the page is mapped and writeable
- if .write = 0, gup_fast() will be fast if the page is mapped
so, using .write = 0 for the xmit path will be faster in more cases than
.write = 1.
When are you seeing gup_fast() fall back to gup()? It should be at most
once per page (when a guest starts up none of its pages are mapped, it
faults them in on demand).
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-08-02 16:32 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-29 11:14 [RFC PATCH v8 00/16] Provide a zero-copy method on KVM virtio-net xiaohui.xin
2010-07-29 11:14 ` xiaohui.xin
2010-07-29 11:14 ` [RFC PATCH v8 01/16] Add a new structure for skb buffer from external xiaohui.xin
2010-07-29 11:14 ` xiaohui.xin
2010-07-29 11:14 ` [RFC PATCH v8 02/16] Add a new struct for device to manipulate external buffer xiaohui.xin
2010-07-29 11:14 ` xiaohui.xin
2010-07-29 11:14 ` [RFC PATCH v8 03/16] Add a ndo_mp_port_prep func to net_device_ops xiaohui.xin
2010-07-29 11:14 ` xiaohui.xin
2010-07-29 11:14 ` [RFC PATCH v8 04/16] Add a function make external buffer owner to query capability xiaohui.xin
2010-07-29 11:14 ` xiaohui.xin
2010-07-29 11:14 ` [RFC PATCH v8 05/16] Add a function to indicate if device use external buffer xiaohui.xin
2010-07-29 11:14 ` xiaohui.xin
2010-07-29 11:14 ` [RFC PATCH v8 06/16] Use callback to deal with skb_release_data() specially xiaohui.xin
2010-07-29 11:14 ` xiaohui.xin
2010-07-29 11:14 ` [RFC PATCH v8 07/16] Modify netdev_alloc_page() to get external buffer xiaohui.xin
2010-07-29 11:14 ` xiaohui.xin
2010-07-29 11:14 ` [RFC PATCH v8 08/16] Modify netdev_free_page() to release " xiaohui.xin
2010-07-29 11:14 ` xiaohui.xin
2010-07-29 11:14 ` [RFC PATCH v8 09/16] Don't do skb recycle, if device use " xiaohui.xin
2010-07-29 11:14 ` xiaohui.xin
2010-07-29 11:14 ` [RFC PATCH v8 10/16] Add a hook to intercept external buffers from NIC driver xiaohui.xin
2010-07-29 11:14 ` xiaohui.xin
2010-07-29 11:14 ` [RFC PATCH v8 11/16] Add header file for mp device xiaohui.xin
2010-07-29 11:14 ` xiaohui.xin
2010-07-29 11:14 ` [RFC PATCH v8 13/16] Add a kconfig entry and make entry " xiaohui.xin
2010-07-29 11:14 ` xiaohui.xin
2010-07-29 11:14 ` [RFC PATCH v8 12/16] Add mp(mediate passthru) device xiaohui.xin
2010-07-29 11:14 ` xiaohui.xin
2010-07-29 11:14 ` [RFC PATCH v8 14/16] Provides multiple submits and asynchronous notifications xiaohui.xin
2010-07-29 11:14 ` xiaohui.xin
2010-07-29 11:14 ` [RFC PATCH v8 15/16] An example how to modifiy NIC driver to use napi_gro_frags() interface xiaohui.xin
2010-07-29 11:14 ` xiaohui.xin
2010-07-29 11:14 ` [RFC PATCH v8 16/16] An example how to alloc user buffer based on " xiaohui.xin
2010-07-29 11:14 ` xiaohui.xin
2010-07-29 22:31 ` [RFC PATCH v8 00/16] Provide a zero-copy method on KVM virtio-net Shirley Ma
2010-07-29 22:31 ` Shirley Ma
2010-07-30 5:02 ` Avi Kivity
2010-07-30 15:46 ` Shirley Ma
2010-08-01 8:18 ` Avi Kivity
2010-08-02 16:01 ` Shirley Ma
2010-08-02 16:11 ` Avi Kivity
2010-08-02 16:25 ` Shirley Ma
2010-08-02 16:32 ` Avi Kivity [this message]
2010-08-11 3:28 ` Shirley Ma
2010-07-30 8:53 ` Xin, Xiaohui
2010-07-30 8:53 ` Xin, Xiaohui
2010-07-30 15:51 ` Shirley Ma
2010-07-30 15:51 ` Shirley Ma
2010-07-31 9:30 ` Arnd Bergmann
2010-07-31 9:30 ` Arnd Bergmann
2010-08-04 2:06 ` Dong, Eddie
2010-08-04 2:06 ` Dong, Eddie
2010-08-04 8:56 ` Arnd Bergmann
2010-08-04 8:56 ` Arnd Bergmann
2010-08-04 17:09 ` Shirley Ma
2010-08-04 17:09 ` Shirley Ma
2010-08-01 8:31 ` Michael S. Tsirkin
2010-08-02 16:04 ` Shirley Ma
2010-08-02 16:10 ` Shirley Ma
2010-08-03 8:48 ` Xin, Xiaohui
2010-08-03 8:48 ` Xin, Xiaohui
2010-08-03 15:50 ` Shirley Ma
2010-08-03 15:50 ` Shirley Ma
2010-08-05 8:52 ` Xin, Xiaohui
2010-08-05 8:52 ` Xin, Xiaohui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C56F318.7030409@redhat.com \
--to=avi@redhat.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=jdike@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mashirle@us.ibm.com \
--cc=mingo@elte.hu \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=xiaohui.xin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.