From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Henningsson Subject: Re: [PATCH] [RESEND] FIX to not expose SPDIF on Thinkpad X301, since it does not have the ability to use SPDIF Date: Tue, 03 Aug 2010 08:16:59 +0200 Message-ID: <4C57B45B.8030709@canonical.com> References: <1280815520.2529.157.camel@laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from adelie.canonical.com (adelie.canonical.com [91.189.90.139]) by alsa0.perex.cz (Postfix) with ESMTP id 602002433C for ; Tue, 3 Aug 2010 08:17:01 +0200 (CEST) In-Reply-To: <1280815520.2529.157.camel@laptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Jerone Young Cc: Takashi Iwai , "alsa-devel@alsa-project.org" List-Id: alsa-devel@alsa-project.org I think Takashi wants you to use "git format-patch" to generate the patch. At least I do so and that has been working well so far. // David 2010-08-03 08:05, Jerone Young skrev: > The Lenovo X301 does not have the ability to connect to a docking > station to use the SPDIF port. It also does not have the ability to do > SPDIF though the headphone jack or Display Port jacks. > > This patch fixes it so this is not exposed for the X301 and users do > think it has the ability to do SPDIF. > > I tested both headphone & display port jacks and it is not there. I have > tested this patch and it works great. > > Also to add the other Thinkpads have different subsystem codec IDs. > Here are examples: > > X301: > http://launchpadlibrarian.net/31561902/Card0.Codecs.codec.0.txt > > X200: > http://launchpadlibrarian.net/49055036/Card0.Codecs.codec.0.txt > > W500: > http://launchpadlibrarian.net/36276057/Card0.Codecs.codec.0.txt > > > Signed-off-by: Jerone Young > > diff --git a/pci/hda/patch_conexant.c b/pci/hda/patch_conexant.c > index c49030b..abc320a 100644 > @@ -2004,6 +2006,11 @@ static int patch_cxt5051(struct hda_codec *codec) > break; > case CXT5051_LENOVO_X200: > spec->init_verbs[0] = cxt5051_lenovo_x200_init_verbs; > + /* Thinkpad X301 does not have S/PDIF wired and no ability > + to use a docking station. */ > + if (codec->subsystem_id == 0x17aa211f) { > + spec->multiout.dig_out_nid = 0; > + } > break; > case CXT5051_F700: > spec->init_verbs[0] = cxt5051_f700_init_verbs; > > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel > -- David Henningsson, Canonical Ltd. http://launchpad.net/~diwic