From: Vincent Hanquez <vincent.hanquez@eu.citrix.com>
To: "Gianni Tedesco (3P)" <gianni.tedesco@citrix.com>
Cc: Ian Campbell <Ian.Campbell@eu.citrix.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 0 of 3] libxl: memory leaks
Date: Tue, 3 Aug 2010 08:59:15 +0100 [thread overview]
Message-ID: <4C57CC53.7030107@eu.citrix.com> (raw)
In-Reply-To: <1280757928.18490.72.camel@qabil.uk.xensource.com>
On 02/08/10 15:05, Gianni Tedesco (3P) wrote:
> It's no big secret or mystery - I only mentioned it because I had
> planned to start work on it quite soon :)
>
> Basically it is to implement properly the current pointer tracking code
> in libxl such that allocations via libxl_(sprintf|malloc) and so on are
> automatically free'd when returning out of the library to a caller.
> Objects returned to callers will still be expected to be free()'d...
What about, what's wrong with the original design ?
the original design being you stuff everything in the context memtrack
and expect all the objects allocated by libxl (internal AND returned to
the caller) to be free by a ctx_free. This provides a strong proven
guarantee that *everything* has been free.
--
Vincent
next prev parent reply other threads:[~2010-08-03 7:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-02 12:31 [PATCH 0 of 3] libxl: memory leaks Ian Campbell
2010-08-02 12:31 ` [PATCH 1 of 3] libxc: free thread specific hypercall buffer on xc_interface_close Ian Campbell
2010-08-02 12:31 ` [PATCH 2 of 3] libxl: fix memory leak in libxl_name_to_domid Ian Campbell
2010-08-02 12:31 ` [PATCH 3 of 3] xl: fix memory leaks in xl create Ian Campbell
2010-08-02 13:11 ` [PATCH 0 of 3] libxl: memory leaks Gianni Tedesco
2010-08-02 13:20 ` Vincent Hanquez
2010-08-02 14:05 ` Gianni Tedesco
2010-08-03 7:59 ` Vincent Hanquez [this message]
2010-08-03 10:18 ` Gianni Tedesco
2010-08-03 10:51 ` Vincent Hanquez
2010-08-03 12:16 ` Gianni Tedesco
2010-08-03 13:37 ` Vincent Hanquez
2010-08-03 14:02 ` Gianni Tedesco
2010-08-03 14:51 ` Ian Campbell
2010-08-03 17:07 ` Stefano Stabellini
2010-08-03 17:11 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C57CC53.7030107@eu.citrix.com \
--to=vincent.hanquez@eu.citrix.com \
--cc=Ian.Campbell@eu.citrix.com \
--cc=gianni.tedesco@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.