All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Chemparathy <cyril@ti.com>
To: "Ramirez Luna, Omar" <omar.ramirez@ti.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"davinci-linux-open-source@linux.davincidsp.com"
	<davinci-linux-open-source@linux.davincidsp.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"Nori, Sekhar" <nsekhar@ti.com>,
	"Govindarajan, Sriramakrishnan" <srk@ti.com>
Subject: Re: [PATCH 1/8] netdev: separate out davinci mdio controller code
Date: Tue, 03 Aug 2010 20:44:41 -0400	[thread overview]
Message-ID: <4C58B7F9.6010608@ti.com> (raw)
In-Reply-To: <27F9C60D11D683428E133F85D2BB4A53043F3C8C2A@dlee03.ent.ti.com>

Hi Omar,

[...]
>> +	while ((reg = __raw_readl(&regs->user[0].access)) & USERACCESS_GO)
>> +		;
> 
> potential infinite loop? I saw another place in your series using time_after, might fit in here too.
[...]
>> +	while ((__raw_readl(&regs->control) & CONTROL_IDLE) == 0)
>> +		;
> 
> Ditto

Thanks.  Will modify.

Regards
Cyril.

  parent reply	other threads:[~2010-08-04  0:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-03 13:31 [PATCH 0/8] split out emac cpdma and mdio for reuse Cyril Chemparathy
2010-08-03 13:31 ` [PATCH 1/8] netdev: separate out davinci mdio controller code Cyril Chemparathy
2010-08-03 23:29   ` Ramirez Luna, Omar
     [not found]   ` <27F9C60D11D683428E133F85D2BB4A53043F3C8C2A@dlee03.ent.ti.com>
2010-08-04  0:44     ` Cyril Chemparathy [this message]
2010-08-03 13:31 ` [PATCH 2/8] davinci: add mdio platform devices Cyril Chemparathy
2010-08-03 14:06   ` Igor Grinberg
2010-08-03 14:32     ` Cyril Chemparathy
2010-08-04  6:58       ` Igor Grinberg
2010-08-03 13:31 ` [PATCH 3/8] netdev: switch davinci emac to new mdio driver Cyril Chemparathy
2010-08-03 13:31 ` [PATCH 4/8] davinci: cleanup unused davinci mdio arch code Cyril Chemparathy
2010-08-03 13:31 ` [PATCH 5/8] netdev: cleanup unused davinci mdio emac code Cyril Chemparathy
2010-08-03 13:31 ` [PATCH 6/8] netdev: separate out davinci cpdma controller code Cyril Chemparathy
2010-08-03 23:30   ` Ramirez Luna, Omar
     [not found]   ` <27F9C60D11D683428E133F85D2BB4A53043F3C8C2B@dlee03.ent.ti.com>
2010-08-04  0:46     ` Cyril Chemparathy
2010-08-03 13:31 ` [PATCH 7/8] netdev: switch davinci emac to new cpdma layer Cyril Chemparathy
2010-08-03 13:31 ` [PATCH 8/8] netdev: cleanup unused davinci emac cpdma code Cyril Chemparathy
2010-08-26 18:39 ` [PATCH 0/8] split out emac cpdma and mdio for reuse Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C58B7F9.6010608@ti.com \
    --to=cyril@ti.com \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nsekhar@ti.com \
    --cc=omar.ramirez@ti.com \
    --cc=srk@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.