From: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
To: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Subject: [PATCH] mount.cifs: remove redundant error assignment
Date: Wed, 04 Aug 2010 12:31:40 +0530 [thread overview]
Message-ID: <4C591054.1070007@suse.de> (raw)
... as it is done anyway at add_mtab_exit.
Signed-off-by: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
---
mount.cifs.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/mount.cifs.c b/mount.cifs.c
index 9f04261..49fdd08 100644
--- a/mount.cifs.c
+++ b/mount.cifs.c
@@ -1513,7 +1513,6 @@ add_mtab(char *devname, char *mountpoint, unsigned long flags, const char *fstyp
rc = lock_mtab();
if (rc) {
fprintf(stderr, "cannot lock mtab");
- rc = EX_FILEIO;
goto add_mtab_exit;
}
@@ -1521,7 +1520,6 @@ add_mtab(char *devname, char *mountpoint, unsigned long flags, const char *fstyp
if (!pmntfile) {
fprintf(stderr, "could not update mount table\n");
unlock_mtab();
- rc = EX_FILEIO;
goto add_mtab_exit;
}
next reply other threads:[~2010-08-04 7:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 7:01 Suresh Jayaraman [this message]
[not found] ` <4C591054.1070007-l3A5Bk7waGM@public.gmane.org>
2010-08-04 10:53 ` Subject: [PATCH] mount.cifs: remove redundant error assignment Jeff Layton
[not found] ` <20100804065338.6fa9d16b-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2010-08-04 11:25 ` Suresh Jayaraman
[not found] ` <4C594E3E.2000903-l3A5Bk7waGM@public.gmane.org>
2010-08-04 11:59 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C591054.1070007@suse.de \
--to=sjayaraman-l3a5bk7wagm@public.gmane.org \
--cc=jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.