From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] x86 emulator: Add stc instruction (opcode 0xf9) Date: Thu, 05 Aug 2010 16:12:07 +0300 Message-ID: <4C5AB8A7.5020509@redhat.com> References: <1281012169-22001-1-git-send-email-m.gamal005@gmail.com> <20100805124939.GM10499@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , mtosatti@redhat.com, kvm@vger.kernel.org To: Mohammed Gamal Return-path: Received: from mx1.redhat.com ([209.132.183.28]:21652 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758978Ab0HENMM (ORCPT ); Thu, 5 Aug 2010 09:12:12 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 08/05/2010 04:01 PM, Mohammed Gamal wrote: > On Thu, Aug 5, 2010 at 3:49 PM, Gleb Natapov wrote: >> On Thu, Aug 05, 2010 at 03:42:49PM +0300, Mohammed Gamal wrote: >>> Signed-off-by: Mohammed Gamal >>> --- >>> arch/x86/kvm/emulate.c | 6 +++++- >>> 1 files changed, 5 insertions(+), 1 deletions(-) >>> >>> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c >>> index f0f4a43..f345df0 100644 >>> --- a/arch/x86/kvm/emulate.c >>> +++ b/arch/x86/kvm/emulate.c >>> @@ -2269,7 +2269,7 @@ static struct opcode opcode_table[256] = { >>> N, N, N, N, >>> D(ImplicitOps | Priv), D(ImplicitOps), G(ByteOp, group3), G(0, group3), >>> /* 0xF8 - 0xFF */ >>> - D(ImplicitOps), N, D(ImplicitOps), D(ImplicitOps), >>> + D(ImplicitOps), D(ImplicitOps), D(ImplicitOps), D(ImplicitOps), >>> D(ImplicitOps), D(ImplicitOps), G(0, group4), G(0, group5), >>> }; >>> >>> @@ -3129,6 +3129,10 @@ special_insn: >>> ctxt->eflags&= ~EFLG_CF; >>> c->dst.type = OP_NONE; /* Disable writeback. */ >>> break; >>> + case 0xf9: /* stc */ >>> + ctxt->eflags |= EFLG_CF; >>> + c->dst.type = OP_NONE; /* Disable writeback */ >> With "disable writeback when decode dest operand" patch (which should be >> applied already) this is no longer needed. > Right. Should I wait for it to be merged and resend? It's merged (in next branch), but I'll just drop that line when applying. -- error compiling committee.c: too many arguments to function