From: Gabor Juhos <juhosg@openwrt.org>
To: Luigi Zambrano <luzambran@gmail.com>
Cc: linux-mtd@lists.infradead.org, dwmw2@infradead.org,
Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH 2/3] mtd: m25p80: add support for the Intel/Numonyx {16, 32, 64}0S33B SPI flash chips
Date: Thu, 05 Aug 2010 16:58:22 +0200 [thread overview]
Message-ID: <4C5AD18E.8030002@openwrt.org> (raw)
In-Reply-To: <AANLkTimkwt3R5CJ7-R8F=14YOwvA89bpj0jbTED4Gbmp@mail.gmail.com>
2010.08.05. 15:19 keltezéssel, Luigi Zambrano írta:
> Actually I’m not sure about this patch. From the datasheet, the 16Mbit
> device has 32 sectors (32*64KB = 16Mbit), the 32Mbit device has 64 sectors
> (64*64KB = 32Mbit) and the 64Mbit device has 128 sectors (128*64KB =
> 64Mbit). So, I think the patch has to be modified in the following way
>
>
>
> + { "160s33b", INFO(0x898911, 0, 64 * 1024, 32, 0) },
>
> + { "320s33b", INFO(0x898912, 0, 64 * 1024, 64, 0) },
>
> + { "640s33b", INFO(0x898913, 0, 64 * 1024, 128, 0) },
>
Oops, you are right. We are using this patch in OpenWrt since a year or so, but
nobody noticed this so far. Good catch, thanks!
I will send a fixed version.
Regards,
Gabor
next parent reply other threads:[~2010-08-05 14:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AANLkTimkwt3R5CJ7-R8F=14YOwvA89bpj0jbTED4Gbmp@mail.gmail.com>
2010-08-05 14:58 ` Gabor Juhos [this message]
2010-08-04 19:14 [PATCH 1/3] mtd: m25p80: add support for the EON EN25P{32, 64} SPI flash chips Gabor Juhos
2010-08-04 19:14 ` [PATCH 2/3] mtd: m25p80: add support for the Intel/Numonyx {16, 32, 64}0S33B " Gabor Juhos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C5AD18E.8030002@openwrt.org \
--to=juhosg@openwrt.org \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=luzambran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.