Re: [PM-SR][PATCH 05/12] omap3: sr: device: check for dev_attr

[Nishanth Menon <menon.nishanth@gmail.com>]

On 08/06/2010 02:27 AM, Gopinath, Thara wrote:
>
>
>>> -----Original Message-----
>>> From: Menon, Nishanth
>>> Sent: Friday, August 06, 2010 3:54 AM
>>> To: linux-omap
>>> Cc: Menon, Nishanth; Kevin Hilman; Gopinath, Thara
>>> Subject: [PM-SR][PATCH 05/12] omap3: sr: device: check for dev_attr
>>>
>>> In the unlikely case that hwmod database is messed up, dont crash
>>> report error and attempt to recover.
>>>
>>> Cc: Kevin Hilman<khilman@deeprootsystems.com>
>>> Cc: Thara Gopinath<thara@ti.com>
>>>
>>> Signed-off-by: Nishanth Menon<nm@ti.com>
>>> ---
>>> arch/arm/mach-omap2/sr_device.c |    6 ++++++
>>> 1 files changed, 6 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-omap2/sr_device.c b/arch/arm/mach-omap2/sr_device.c
>>> index 7d13704..6f70da6 100644
>>> --- a/arch/arm/mach-omap2/sr_device.c
>>> +++ b/arch/arm/mach-omap2/sr_device.c
>>> @@ -130,6 +130,12 @@ static int sr_dev_init(struct omap_hwmod *oh, void *user)
>>> 	}
>>>
>>> 	sr_dev_data = (struct omap_sr_dev_data *)oh->dev_attr;
>>> +	if (unlikely(!sr_dev_data)) {
>>> +		pr_err("%s: Bad oh->dev_attr!\n", __func__);
>>> +		kfree(sr_data);
>>> +		return -EINVAL;
>>> +	}
>
> Taken in after modifications as per the reply for patch 06/12

I dont agree to the mod of 06/12. sorry.

Regards,
Nishanth Menon