From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] test: Add test for setcc instruction Date: Fri, 06 Aug 2010 13:04:29 +0200 Message-ID: <4C5BEC3D.8060405@redhat.com> References: <4C5BD1AD.10207@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Cc: Avi Kivity , kvm@vger.kernel.org To: Wei Yongjun Return-path: Received: from mail-fx0-f46.google.com ([209.85.161.46]:39708 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756901Ab0HFLEe (ORCPT ); Fri, 6 Aug 2010 07:04:34 -0400 Received: by fxm14 with SMTP id 14so3735934fxm.19 for ; Fri, 06 Aug 2010 04:04:33 -0700 (PDT) In-Reply-To: <4C5BD1AD.10207@cn.fujitsu.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/06/2010 11:11 AM, Wei Yongjun wrote: > Signed-off-by: Wei Yongjun > > diff --git a/x86/emulator.c b/x86/emulator.c > index e278812..5c8093e 100644 > --- a/x86/emulator.c > +++ b/x86/emulator.c > @@ -375,6 +375,44 @@ void test_btc(void *mem) > report("btcl reg, r/m", a[0] == 1&& a[1] == 2&& a[2] == 0x80000004); > } > > +void test_setcc(void *mem) > +{ > + unsigned char *memb = mem; > + > + asm ("seto %0":"=m"(*memb)); > + report("seto r/m8", *memb == 0); > + asm ("setno %0":"=m"(*memb)); > + report("setno r/m8", *memb == 1); > + asm ("setc %0":"=m"(*memb)); > + report("setc r/m8", *memb == 0); > + asm ("setnc %0":"=m"(*memb)); > + report("setnc r/m8", *memb == 1); > + asm ("sete %0":"=m"(*memb)); > + report("setz r/m8", *memb == 0); > + asm ("setne %0":"=m"(*memb)); > + report("setnz r/m8", *memb == 1); > + asm ("seta %0":"=m"(*memb)); > + report("seta r/m8", *memb == 1); > + asm ("setna %0":"=m"(*memb)); > + report("setna r/m8", *memb == 0); > + asm ("sets %0":"=m"(*memb)); > + report("sets r/m8", *memb == 0); > + asm ("setns %0":"=m"(*memb)); > + report("setns r/m8", *memb == 1); > + asm ("setp %0":"=m"(*memb)); > + report("setp r/m8", *memb == 0); > + asm ("setnp %0":"=m"(*memb)); > + report("setnp r/m8", *memb == 1); > + asm ("setl %0":"=m"(*memb)); > + report("setl r/m8", *memb == 0); > + asm ("setnl %0":"=m"(*memb)); > + report("setnl r/m8", *memb == 1); > + asm ("setle %0":"=m"(*memb)); > + report("setle r/m8", *memb == 0); > + asm ("setnle %0":"=m"(*memb)); > + report("setnle r/m8", *memb == 1); > +} These results depend on the environment, since you do not know which instruction last set the flags. You can add a mov+cmp pair before the setcc instruction to guarantee that the flags are set correctly. Paolo