From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/6] phonesim: Don't use VENDOR_PHONESIM for Calypso.
Date: Fri, 06 Aug 2010 12:17:58 -0500 [thread overview]
Message-ID: <4C5C43C6.6090300@gmail.com> (raw)
In-Reply-To: <1281029457-9048-1-git-send-email-andrew.zaborowski@intel.com>
[-- Attachment #1: Type: text/plain, Size: 947 bytes --]
Hi Andrew,
On 08/05/2010 12:30 PM, Andrzej Zaborowski wrote:
> Also move the STK initialisation to post-sim because it is more logical
> there (even if it makes no difference under phonesim).
>
> I'm not sure if there's any user of the "calypso" mode in phonesim
> driver now, perhaps it can be removed.
Could you please do me a favor and put 'comment' paragraphs in the
git-send-email block specifically designated for this? These are fairly
context specific questions and make no sense to be included in the
commit history. I have to git --amend and take them out manually.
To answer your question, we use 'calypso' driver for phonesim when using
the Freerunner modem over TCP. This way oFono can be quickly run and
tested without the need to cross-compile. This part is still useful in
certain circumstances, so it is safe to leave it in for now...
All patches in this series have been applied.
Regards,
-Denis
prev parent reply other threads:[~2010-08-06 17:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-05 17:30 [PATCH 1/6] phonesim: Don't use VENDOR_PHONESIM for Calypso Andrzej Zaborowski
2010-08-05 17:30 ` [PATCH 2/6] calypso: Check if SIM is present on modem startup Andrzej Zaborowski
2010-08-05 17:30 ` [PATCH 3/6] calypsomodem: Add a Calypso STK driver Andrzej Zaborowski
2010-08-06 17:19 ` Denis Kenzior
2010-08-06 17:45 ` Andrzej Zaborowski
2010-08-05 17:30 ` [PATCH 4/6] calypso: Enable AT extended error codes Andrzej Zaborowski
2010-08-06 17:17 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C5C43C6.6090300@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.