From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] gprs: Fix release cid in gprs_deactive_for_remove
Date: Mon, 09 Aug 2010 09:11:29 -0500 [thread overview]
Message-ID: <4C600C91.7000501@gmail.com> (raw)
In-Reply-To: <1281346091-24758-1-git-send-email-zhenhua.zhang@intel.com>
[-- Attachment #1: Type: text/plain, Size: 802 bytes --]
Hi Zhenhua,
On 08/09/2010 04:28 AM, Zhenhua Zhang wrote:
> Similiar to pri_deactive_callback, we should release the context id in
> gprs_deactive_for_remove() as well.
> ---
> src/gprs.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/src/gprs.c b/src/gprs.c
> index 8d807dd..2c5bb4e 100644
> --- a/src/gprs.c
> +++ b/src/gprs.c
> @@ -1262,6 +1262,9 @@ static void gprs_deactivate_for_remove(const struct ofono_error *error,
> return;
> }
>
> + gprs_cid_release(gprs, ctx->context.cid);
> + ctx->context.cid = 0;
> +
> if (gprs->settings) {
> g_key_file_remove_group(gprs->settings, ctx->key, NULL);
> storage_sync(gprs->imsi, SETTINGS_STORE, gprs->settings);
Great catch. Patch has been applied, thanks.
Regards,
-Denis
prev parent reply other threads:[~2010-08-09 14:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-09 9:28 [PATCH] gprs: Fix release cid in gprs_deactive_for_remove Zhenhua Zhang
2010-08-09 14:11 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C600C91.7000501@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.