From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Christie Subject: Re: [PATCH 1/5] fc class: add fc host default default dev loss setting Date: Mon, 09 Aug 2010 10:00:31 -0500 Message-ID: <4C60180F.5030209@cs.wisc.edu> References: <1281081761-24586-1-git-send-email-michaelc@cs.wisc.edu> <1281081761-24586-2-git-send-email-michaelc@cs.wisc.edu> <4C601681.3020807@emulex.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from sabe.cs.wisc.edu ([128.105.6.20]:42873 "EHLO sabe.cs.wisc.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756844Ab0HIPBJ (ORCPT ); Mon, 9 Aug 2010 11:01:09 -0400 In-Reply-To: <4C601681.3020807@emulex.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: James Smart Cc: "linux-scsi@vger.kernel.org" , "jeykholt@cisco.com" , "andrew.vasquez@qlogic.com" , "giridhar.malavali@qlogic.com" , "brking@us.ibm.com" On 08/09/2010 09:53 AM, James Smart wrote: > Mike, > > why the motivation to get the dev_loss_tmo from the LLDD ? I would have > assumed this would have become a base fc_host attribute which is rd/wr, > the default coming from the module parameter, with the "set" propagating > to the LLDD to change all rports to the host value (either new direct > callback, or loop which calls rport set routine). qla2xxx and fnic set the default/initial dev_loss_tmo based on some value they get from firmware. Should I allow either where a lld can override it if they want to set it based on fw/hw info. If I do this should I keep the lpfc dev_loss_tmo on the scsi_host for backward compat and then add the fc_host r/w attr for it too? > > - james s > > > michaelc@cs.wisc.edu wrote: >> From: Mike Christie >> >> This patch adds a fc_host setting to store the >> default dev_loss_tmo. It is used if the driver >> has a callack to get the value from the LLD. If >> the callback is not set, then we use the fc class >> module default value. >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html