From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: Fix faulty definition of uec_initialize()
Date: Mon, 09 Aug 2010 13:54:10 -0700 [thread overview]
Message-ID: <4C606AF2.30900@gmail.com> (raw)
In-Reply-To: <AANLkTineNUmOUcfbMdP_NK6aiv1vfBG+jNe4MLgYVGJn@mail.gmail.com>
On 8/9/2010 1:18 PM, Mike Frysinger wrote:
> On Mon, Aug 9, 2010 at 3:15 PM, Joakim Tjernlund wrote:
>> The correct definition is in drivers/qe/uec.h so just
>> include that one instead.
> ... except that bleeds a ton of crap from uec.h into the global
> namespace for everyone. better would be to move the prototype out of
> uec.h and into netdev.h and make sure uec.h includes netdev.h.
> -mike
> _______
Agreed. Please find a way to have UEC-related stuff only on boards that
care about it.
regards,
Ben
next prev parent reply other threads:[~2010-08-09 20:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-09 19:15 [U-Boot] [PATCH] net: Fix faulty definition of uec_initialize() Joakim Tjernlund
2010-08-09 20:18 ` Mike Frysinger
2010-08-09 20:54 ` Ben Warren [this message]
2010-08-10 5:52 ` Joakim Tjernlund
2010-08-10 6:04 ` Mike Frysinger
2010-08-10 12:10 ` Joakim Tjernlund
2010-08-19 7:37 ` [U-Boot] [PATCHv2] " Joakim Tjernlund
2010-08-31 6:02 ` Ben Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C606AF2.30900@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.