From: Randy Dunlap <randy.dunlap@oracle.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
gregkh@suse.de, lud <linux-usb@vger.kernel.org>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
David Brownell <dbrownell@users.sourceforge.net>
Subject: Re: [patch -NEXT] usb/gadget/webcam: fix Kconfig depends again
Date: Tue, 10 Aug 2010 07:48:57 -0700 [thread overview]
Message-ID: <4C6166D9.60607@oracle.com> (raw)
In-Reply-To: <201008101416.31188.laurent.pinchart@ideasonboard.com>
On 08/10/10 05:16, Laurent Pinchart wrote:
> Hi Randy,
>
> Thanks for the patch.
>
> On Monday 09 August 2010 19:55:20 Randy Dunlap wrote:
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> The USB gadget webcam driver uses V4L2 interfaces, so it should depend
>> on VIDEO_V4L2 instead of VIDEO_DEV. This fixes a lot of build errors
>> when V4L2 is not enabled:
>>
>> ERROR: "v4l2_event_unsubscribe" [drivers/usb/gadget/g_webcam.ko] undefined!
>> ERROR: "v4l2_event_queue" [drivers/usb/gadget/g_webcam.ko] undefined!
>> ERROR: "video_device_release" [drivers/usb/gadget/g_webcam.ko] undefined!
>> ERROR: "video_usercopy" [drivers/usb/gadget/g_webcam.ko] undefined!
>> ERROR: "v4l2_event_dequeue" [drivers/usb/gadget/g_webcam.ko] undefined!
>> ERROR: "video_register_device" [drivers/usb/gadget/g_webcam.ko] undefined!
>> ERROR: "video_device_alloc" [drivers/usb/gadget/g_webcam.ko] undefined!
>> ERROR: "v4l2_event_subscribe" [drivers/usb/gadget/g_webcam.ko] undefined!
>> ERROR: "video_unregister_device" [drivers/usb/gadget/g_webcam.ko]
>> undefined!
>> ERROR: "v4l2_fh_init" [drivers/usb/gadget/g_webcam.ko] undefined!
>> ERROR: "v4l2_event_pending" [drivers/usb/gadget/g_webcam.ko] undefined!
>> ERROR: "v4l2_event_init" [drivers/usb/gadget/g_webcam.ko] undefined!
>> ERROR: "video_devdata" [drivers/usb/gadget/g_webcam.ko] undefined!
>> ERROR: "v4l2_event_alloc" [drivers/usb/gadget/g_webcam.ko] undefined!
>> ERROR: "v4l2_fh_add" [drivers/usb/gadget/g_webcam.ko] undefined!
>> ERROR: "v4l2_fh_del" [drivers/usb/gadget/g_webcam.ko] undefined!
>> ERROR: "v4l2_fh_exit" [drivers/usb/gadget/g_webcam.ko] undefined!
>
> All those symbols should be defined when VIDEO_DEV is selected.
>
>> ERROR: "v4l2_ctrl_fill" [drivers/media/video/v4l2-common.ko] undefined!
>> ERROR: "v4l2_ctrl_get_menu" [drivers/media/video/v4l2-common.ko] undefined!
>
> Those 2 symbols require VIDEO_V4L2 but are not used by the webcam gadget
> driver.
>
>> ERROR: "v4l2_device_unregister_subdev" [drivers/media/video/v4l2-common.ko]
>> undefined!
>> ERROR: "v4l2_device_register_subdev" [drivers/media/video/v4l2-common.ko]
>> undefined!
>
> Those two symbols should be defined when VIDEO_DEV is selected. They are not
> used by the webcam gadget driver.
>
Summary: I should drop this patch and look elsewhere for the problem,
Right?
Thanks for your help.
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2010-08-10 14:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-09 3:23 linux-next: Tree for August 9 Stephen Rothwell
2010-08-09 17:08 ` linux-next: Tree for August 9 (nfs) Randy Dunlap
[not found] ` <20100809100856.b03a9bc1.randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2010-08-12 16:18 ` Randy Dunlap
2010-08-12 16:18 ` Randy Dunlap
[not found] ` <20100812091842.6a3b84b9.randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2010-08-12 17:31 ` Trond Myklebust
2010-08-12 17:31 ` Trond Myklebust
2010-08-12 17:36 ` Randy Dunlap
[not found] ` <4C643136.5090808-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2010-08-17 21:23 ` Trond Myklebust
2010-08-17 21:23 ` Trond Myklebust
[not found] ` <1282080208.12506.7.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2010-08-17 21:39 ` Randy Dunlap
2010-08-17 21:39 ` Randy Dunlap
2010-08-17 21:39 ` Randy Dunlap
2010-08-09 17:55 ` [patch -NEXT] usb/gadget/webcam: fix Kconfig depends again Randy Dunlap
2010-08-10 12:16 ` Laurent Pinchart
2010-08-10 14:48 ` Randy Dunlap [this message]
[not found] ` <4C6166D9.60607-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2010-08-10 14:53 ` Laurent Pinchart
2010-08-10 14:53 ` Laurent Pinchart
[not found] ` <201008101653.08358.laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2010-08-17 18:03 ` Randy Dunlap
2010-08-17 18:03 ` Randy Dunlap
2010-08-09 17:56 ` [PATCH -next] v4l2-ctrls.c: needs to include slab.h Randy Dunlap
2010-08-11 18:45 ` Tony Vroon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6166D9.60607@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=dbrownell@users.sourceforge.net \
--cc=gregkh@suse.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.