From: David Scherba <dscherba@codeaurora.org>
To: linux-bluetooth@vger.kernel.org
Cc: marcel@holtmann.org, rshaffer@codeaurora.org
Subject: Re: [PATCH 1/2] Remove non-functional hci_devinfo calls in init_device()
Date: Tue, 10 Aug 2010 10:12:25 -0500 [thread overview]
Message-ID: <4C616C59.9040401@codeaurora.org> (raw)
In-Reply-To: <20100809215149.GA25488@jh-x301>
On 8/9/2010 4:51 PM, Johan Hedberg wrote:
> Nice catch, but that's not quite enough:
>
> plugins/hciops.c: In function ‘init_device’:
> plugins/hciops.c:178: error: label ‘done’ defined but not used
> plugins/hciops.c:125: error: unused variable ‘di’
>
> Always check that your patch compiles cleanly with ./bootstrap-configure
> before submitting upstream.
Johan--
Thanks for the tips--I had split-up a combined patch and neglected to
ensure clean compilation and spacing after the split :-(.
New patch versions coming your way...
Cheers,
David
--
David Scherba
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum
next prev parent reply other threads:[~2010-08-10 15:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-09 21:07 [PATCH 0/2] Use HCI device type to determine suitability of HCI commands David Scherba
2010-08-09 21:07 ` [PATCH 1/2] Remove non-functional hci_devinfo calls in init_device() David Scherba
2010-08-09 21:51 ` Johan Hedberg
2010-08-10 15:12 ` David Scherba [this message]
2010-08-09 21:07 ` [PATCH 2/2] Use HCI device type to gate BR/EDR-specific HCI commands David Scherba
2010-08-09 21:59 ` Johan Hedberg
-- strict thread matches above, loose matches on Subject: below --
2010-08-10 15:15 [PATCH v2 0/2] Use HCI device type to determine suitability of " David Scherba
2010-08-10 15:15 ` [PATCH 1/2] Remove non-functional hci_devinfo calls in init_device() David Scherba
2010-08-10 19:20 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C616C59.9040401@codeaurora.org \
--to=dscherba@codeaurora.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=rshaffer@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.