From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Furniss Subject: Re: [PATCH] drm/radeon/kms: r600 CS parser fixes Date: Tue, 10 Aug 2010 16:14:15 +0100 Message-ID: <4C616CC7.3070302@ukfsn.org> References: <1281077645-10775-1-git-send-email-alexdeucher@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.ukfsn.org (mail.ukfsn.org [77.75.108.10]) by gabe.freedesktop.org (Postfix) with ESMTP id 0D3369E73F for ; Tue, 10 Aug 2010 08:36:45 -0700 (PDT) In-Reply-To: <1281077645-10775-1-git-send-email-alexdeucher@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Alex Deucher Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org Alex Deucher wrote: > - buffer offsets in the base regs are 256b aligned so > shift properly when comparing, fixed by Andre Maasikas > - mipmap size was calculated wrong when nlevel=0 > - texture bo offsets were used after the bo base address was added > - vertex resource size register is size - 1, not size I tried this patch on a d-r-t from 100805 (todays d-r-t seems to have reverted to a month ago and doesn't work well with tiling) The patch, while fixing mesa demos lodbias and cubemap, seems to regress ut2004 and doom3 demos - radeon 0000:01:00.0: mipmap bo too small (128 128 4 0 7 393216 -> 458816 have 655360)