All of lore.kernel.org
 help / color / mirror / Atom feed
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] lpc32xx/clock: Use && instead of &
Date: Tue, 10 Aug 2010 19:42:21 +0400	[thread overview]
Message-ID: <4C61735D.40602@ru.mvista.com> (raw)
In-Reply-To: <1281451732-19294-1-git-send-email-w.sang@pengutronix.de>

Hello.

Wolfram Sang wrote:

> Because we are connecting two expressions here, not binary values.

> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> Cc: Kevin Wells <wellsk40@gmail.com>
> ---
>  arch/arm/mach-lpc32xx/clock.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

> diff --git a/arch/arm/mach-lpc32xx/clock.c b/arch/arm/mach-lpc32xx/clock.c
> index 32d6379..9ff1438 100644
> --- a/arch/arm/mach-lpc32xx/clock.c
> +++ b/arch/arm/mach-lpc32xx/clock.c
> @@ -397,7 +397,7 @@ static int local_usbpll_enable(struct clk *clk, int enable)
>  		__raw_writel(reg, LPC32XX_CLKPWR_USB_CTRL);
>  
>  		/* Wait for PLL lock */
> -		while ((timeout > jiffies) & (ret == -ENODEV)) {
> +		while ((timeout > jiffies) && (ret == -ENODEV)) {

    Could also kill unnecessary parens, while at it...

WBR, Sergei

  reply	other threads:[~2010-08-10 15:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-10 14:48 [PATCH] lpc32xx/clock: Use && instead of & Wolfram Sang
2010-08-10 15:42 ` Sergei Shtylyov [this message]
2010-08-19 22:50 ` Kevin Wells
2010-08-20  6:31   ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C61735D.40602@ru.mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.