Re: [PATCH 1/2] ipr: fix resource address formatting and add attribute for device ID

[Brian King <brking@linux.vnet.ibm.com>]

On 08/10/2010 11:12 AM, Wayne Boyer wrote:
> Index: b/drivers/scsi/ipr.h
> ===================================================================
> --- a/drivers/scsi/ipr.h	2010-08-05 11:23:35.000000000 -0700
> +++ b/drivers/scsi/ipr.h	2010-08-09 10:09:04.000000000 -0700
> @@ -372,7 +372,7 @@ struct ipr_config_table_entry {
> 
>  	struct ipr_res_addr res_addr;
>  	__be32 res_handle;
> -	__be32 reserved4[2];
> +	__be64 lun_wwn;
>  	struct ipr_std_inq_data std_inq_data;
>  }__attribute__ ((packed, aligned (4)));
> 
> @@ -1210,6 +1210,7 @@ struct ipr_resource_entry {
> 
>  	__be32 res_handle;
>  	__be64 dev_id;
> +	__be64 lun_wwn;

This should be two __be32's or just an array of u8's instead,
since this field is not aligned on an 8 byte boundary. You can
use the unaligned accessors to make it easier to deal with.

Thanks,

Brian

-- 
Brian King
Linux on Power Virtualization
IBM Linux Technology Center