From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [RFC PATCH 3/3] VMX: Emulated real mode interrupt injection
Date: Tue, 10 Aug 2010 18:52:47 -0400
Message-ID: <4C61D83F.8050305@redhat.com>
References: <1281295456-11114-1-git-send-email-m.gamal005@gmail.com>	<1281295456-11114-4-git-send-email-m.gamal005@gmail.com>	<4C60C17E.1090606@redhat.com> <AANLkTi=wyYv1JhH-0=BiRUdobhptM=nLvBMrtKnn1KM1@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: mtosatti@redhat.com, kvm@vger.kernel.org,
	Jan Kiszka <jan.kiszka@siemens.com>
To: Mohammed Gamal <m.gamal005@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:17079 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756150Ab0HJWw5 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 10 Aug 2010 18:52:57 -0400
In-Reply-To: <AANLkTi=wyYv1JhH-0=BiRUdobhptM=nLvBMrtKnn1KM1@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

  On 08/10/2010 01:13 PM, Mohammed Gamal wrote:
>
>>
>>> -               vmcs_write32(VM_ENTRY_INTR_INFO_FIELD,
>>> -                            irq | INTR_TYPE_SOFT_INTR |
>>> INTR_INFO_VALID_MASK);
>>> -               vmcs_write32(VM_ENTRY_INSTRUCTION_LEN, 1);
>>> -               kvm_rip_write(vcpu, vmx->rmode.irq.rip - 1);
>>> +               inject_realmode_interrupt(vcpu, irq);
>>>                 return;
>>>         }
>> Error checks?
> We return anyway. Is there somwhere in the vmcs where an error is
> indicated (e.g. setting some flag or variable)? Or should we probably
> let vmx_inject_irq() return an integer return value?

That's too complicated for now.  I guess you can KVM_REQ_TRIPLE_FAULT, 
and the guest will reset.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.