All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	Cam Macdonell <cam@cs.ualberta.ca>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH 2/2] ivshmem: Fix compilation without kvm
Date: Wed, 11 Aug 2010 13:05:16 -0400	[thread overview]
Message-ID: <4C62D84C.5020405@redhat.com> (raw)
In-Reply-To: <1281512334-4268-2-git-send-email-weil@mail.berlios.de>

On 08/11/2010 03:38 AM, Stefan Weil wrote:
> kvm_set_ioeventfd_mmio_long is only available with CONFIG_KVM.

We should just disable ivshmem for non-KVM

diff --git a/Makefile.target b/Makefile.target
index b791492..c8281e9 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -191,7 +191,7 @@ obj-y += rtl8139.o
  obj-y += e1000.o

  # Inter-VM PCI shared memory
-obj-y += ivshmem.o
+obj-$(CONFIG_KVM) += ivshmem.o

  # Hardware support
  obj-i386-y += vga.o

because it is also breaking Windows builds.

Alternatively, the right way to do what this patch does, is to add 
kvm_set_ioeventfd_mmio_long to kvm-stub.c, and to use 
"obj-$(CONFIG_POSIX) += ivshmem.o" in the makefile to work around the 
Windows build problems.

Paolo

  reply	other threads:[~2010-08-11 17:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-11  7:38 [Qemu-devel] [PATCH 1/2] ivshmem: Fix compilation (wrong format specifier) Stefan Weil
2010-08-11  7:38 ` [Qemu-devel] [PATCH 2/2] ivshmem: Fix compilation without kvm Stefan Weil
2010-08-11 17:05   ` Paolo Bonzini [this message]
2010-08-11 17:18     ` [Qemu-devel] " Blue Swirl
2010-08-11 18:11       ` Paolo Bonzini
2010-08-11 17:58     ` Cam Macdonell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C62D84C.5020405@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=cam@cs.ualberta.ca \
    --cc=qemu-devel@nongnu.org \
    --cc=weil@mail.berlios.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.