From: Sergei Shtylyov <sshtylyov@mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] USB-CDC: correct wrong alignment in ether.c
Date: Thu, 12 Aug 2010 14:35:07 +0400 [thread overview]
Message-ID: <4C63CE5B.9030707@mvista.com> (raw)
In-Reply-To: <1281562849-6548-1-git-send-email-sbabic@denx.de>
Hello.
Stefano Babic wrote:
> The buffer for the status request must be word aligned
> because it is accessed with 32 bit pointer in the
> eth_status_complete function.
You don't tell anything here about why the size of the array becomes 16x
with your patch...
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> ---
> drivers/usb/gadget/ether.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c
> index 313f15f..9f9b093 100644
> --- a/drivers/usb/gadget/ether.c
> +++ b/drivers/usb/gadget/ether.c
> @@ -684,7 +684,7 @@ static struct usb_gadget_strings stringtab = {
>
> /*============================================================================*/
> static u8 control_req[USB_BUFSIZ];
> -static u8 status_req[STATUS_BYTECOUNT];
> +static u8 status_req[STATUS_BYTECOUNT * 16] __attribute__ ((aligned(32)));
WBR, Sergei
next prev parent reply other threads:[~2010-08-12 10:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 21:40 [U-Boot] [PATCH] USB-CDC: correct wrong alignment in ether.c Stefano Babic
2010-08-12 10:35 ` Sergei Shtylyov [this message]
2010-08-12 12:21 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C63CE5B.9030707@mvista.com \
--to=sshtylyov@mvista.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.