From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rogan Dawes <rogan@dawes.za.net>
Date: Thu, 12 Aug 2010 13:52:19 +0200
Subject: [U-Boot] [PATCH] MTD: Cleanup jffs2/mtdpart headers
In-Reply-To: <1281613417-19585-1-git-send-email-sr@denx.de>
References: <1281613417-19585-1-git-send-email-sr@denx.de>
Message-ID: <4C63E073.9040701@dawes.za.net>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 2010/08/12 1:43 PM, Stefan Roese wrote:
> This patch moves some MTD related defines and prototypes from a jffs2
> header to an MTD header. This makes it possible to remove this jffs2
> header inclusion from some files without jffs2 relevance.
>
> Signed-off-by: Stefan Roese<sr@denx.de>
> Cc: Alexander Stein<alexander.stein@systec-electronic.com>

Just two comments.

> +struct part_info {
> +	struct list_head link;
> +	char *name;			/* partition name */
> +	u8 auto_name;			/* set to 1 for generated name */
> +	u32 size;			/* total size of the partition */
> +	u32 offset;			/* offset within device */
> +	void *jffs2_priv;		/* used internaly by jffs2 */

Should this really be in here? Seems we are mixing things up still.

>   /* XXX U-BOOT XXX */
>   #if 0
>   struct mtd_notifier {

What's up with "#if 0" code in the src?

Rogan