From: Trilok Soni <tsoni@codeaurora.org>
To: David Brown <davidb@codeaurora.org>
Cc: Neil Leeder <nleeder@codeaurora.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, Horace Fu <horace.fu@quantatw.com>,
Mandeep Singh Baines <msb@chromium.org>
Subject: Re: [PATCH 1/1] mouse: add qci touchpad driver
Date: Thu, 12 Aug 2010 20:06:08 +0530 [thread overview]
Message-ID: <4C6406D8.2090401@codeaurora.org> (raw)
In-Reply-To: <20100810232014.GB21240@huya.qualcomm.com>
Hi David,
On 8/11/2010 4:50 AM, David Brown wrote:
> On Sat, Aug 07, 2010 at 04:14:54PM +0530, Trilok Soni wrote:
>
>>> +
>>> +/*
>>> + * Driver communicates over i2c to nuvoTon WPCE775x Embedded Controller,
>>> + * which has touchpad attached through PS/2 interface.
>>> + */
>>
>> Why this driver is not developed through MFD architecture then? nuvoTon chip
>> looks like multi-function chip, isn't it?
>
> It is, in the sense that it does multiple things. But, for this
> particular device, it makes the keyboard available as an i2c device.
> I don't see any particular reason to tie that to other functionality
> that the chip provides.
Ok, agreed. Neil, please submit a new patch with addressing other comments. Thanks.
---Trilok Soni
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
prev parent reply other threads:[~2010-08-12 14:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-06 20:32 [PATCH 1/1] mouse: add qci touchpad driver Neil Leeder
2010-08-07 10:44 ` Trilok Soni
2010-08-10 23:20 ` David Brown
2010-08-12 14:36 ` Trilok Soni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6406D8.2090401@codeaurora.org \
--to=tsoni@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=dmitry.torokhov@gmail.com \
--cc=horace.fu@quantatw.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msb@chromium.org \
--cc=nleeder@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.