From: Paolo Bonzini <pbonzini@redhat.com>
To: Wei Yongjun <yjwei@cn.fujitsu.com>
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH 2/2] KVM: x86 emulator: add XADD instruction emulation
Date: Thu, 12 Aug 2010 11:34:37 -0400 [thread overview]
Message-ID: <4C64148D.4080103@redhat.com> (raw)
In-Reply-To: <4C63FA04.3030403@cn.fujitsu.com>
On 08/12/2010 09:41 AM, Wei Yongjun wrote:
> + case 0xc0 ... 0xc1: /* xadd */
> + /* Write back the register source. */
> + write_register_operand(&c->src, c->dst.val, c->dst.bytes);
> + /* Write back the memory destination with implicit LOCK prefix. */
> + c->lock_prefix = 1;
It's not a major performance problem, but xadd does _not_ have an
implicit LOCK prefix.
Paolo
next prev parent reply other threads:[~2010-08-12 15:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-12 13:38 [PATCH 1/2] KVM: x86 emulator: put register operand write back to a function Wei Yongjun
2010-08-12 13:41 ` [PATCH 2/2] KVM: x86 emulator: add XADD instruction emulation Wei Yongjun
2010-08-12 15:34 ` Paolo Bonzini [this message]
2010-08-13 5:13 ` [PATCH 2/2 v2] " Wei Yongjun
2010-08-13 5:32 ` [PATCH 2/2 v3] " Wei Yongjun
2010-08-15 11:30 ` [PATCH 1/2] KVM: x86 emulator: put register operand write back to a function Avi Kivity
[not found] ` <4C689B56.4000405@cn.fujitsu.com>
2010-08-16 8:55 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C64148D.4080103@redhat.com \
--to=pbonzini@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=yjwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.