From: Sergei Shtylyov <sshtylyov@mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] USB-CDC: wrong ep status used
Date: Thu, 12 Aug 2010 21:05:53 +0400 [thread overview]
Message-ID: <4C6429F1.7080304@mvista.com> (raw)
In-Reply-To: <4C63E8F8.2090205@denx.de>
Hello.
Stefano Babic wrote:
>> On 08/12/2010 01:41 AM, Stefano Babic wrote:
>>> #if defined(DEV_CONFIG_CDC)
>>> if (dev->status_ep) {
>>> - dev->stat_req = usb_ep_alloc_request(gadget->ep0, GFP_KERNEL);
>>> - dev->stat_req->buf = status_req;
>>> + dev->stat_req = usb_ep_alloc_request(dev->status_ep, GFP_KERNEL);
>>> if (!dev->stat_req) {
>>> dev->stat_req->buf=NULL;
>> We get oops here!
> Agree, and the issue is not related to this patch, I missed to correct
> it, thanks. If no one complains, I will send a single patch to fix both
> problems (wrong ep status + null pointer access).
Looks like Vitaly has done the same already:
http://lists.denx.de/pipermail/u-boot/2010-August/075419.html
> Best regards,
> Stefano
WBR, Sergei
next prev parent reply other threads:[~2010-08-12 17:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 21:41 [U-Boot] [PATCH] USB-CDC: wrong ep status used Stefano Babic
2010-08-12 10:13 ` Vitaly Kuzmichev
2010-08-12 12:28 ` Stefano Babic
2010-08-12 17:05 ` Sergei Shtylyov [this message]
2010-08-13 9:16 ` Vitaly Kuzmichev
2010-08-13 9:19 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6429F1.7080304@mvista.com \
--to=sshtylyov@mvista.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.