All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <tom_rini@mentor.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [RFC] Disable packaged-staging for perl-native
Date: Thu, 12 Aug 2010 12:00:47 -0700	[thread overview]
Message-ID: <4C6444DF.40206@mentor.com> (raw)
In-Reply-To: <201008122129.08412.roman@khimov.ru>

Roman I Khimov wrote:
> В сообщении от Четверг 12 августа 2010 21:12:22 автор Tom Rini написал:
>> Tom Rini wrote:
>>> Roman I Khimov wrote:
>>>> В сообщении от Среда 28 июля 2010 03:45:21 автор Tom Rini написал:
>>>>> I'd like to disable packaged-staging for perl-native.  The problem here
>>>>> comes from a number of things that happen.  Some of these can only
>>>>> happen in combination with packaged-staging but others I believe could
>>>>> happen today.  The problem itself is that if we have perl-native
>>>>> available from packaged-staging it can suddenly exist very early.  What
>>>>> this means in practical terms is that now we're trying to generate say
>>>>> pod2man.pl from pod2man.pl.in and @perl@ is expanded to something
>>>>> beyond the "#!" mechanic length limit and recipes start failing to
>>>>> build (fixable by changing pod2man.pl.in to use /usr/bin/env perl (and
>>>>> if it had a -w changing to Use warnings: or whatever the perl is)).
>>>> So the problem really is that we have perl in
>>>> /very-very-long-path/perl? IMO /usr/bin/env change would be better in
>>>> that case.
>>> The most common case is that one, yes.  I'm open to suggestions on
>>> catching and fixing these problems ahead of time but the issue is we're
>>> talking about for example wget which has no dependency on perl-native.
>> As I go over the list of stuff to get a "1.0" of relocatable packaged
>> staging done, ping?  Blacklist perl-native for now or someone suggest
>> how to catch and fixup all the cases to be /usr/bin/env perl ?  iirc
>> just setting ac_cv...="/usr/bin/env perl" won't do it since we end up
>> trying to invoke /usr/bin/env perl -w sometimes and that's an error.
> 
> Well, IMO, blacklisting just doesn't fix the problem here if the problem is 
> /long/long/long/path/to/perl. Because whether from packaged staging or from 
> really built perl-native the perl will be there anyway and so is the chance of 
> breakage.

Yes, it's a very broken thing Today.  It's just rarely if ever hit 
today.  But with packaged staging it happens a lot, especially when you 
have a lot of threads.

> Maybe some automatic
> 
> $ sed -ri "s,#!.\s*${STAGING_NATIVE_BINDIR}/perl,#!/usr/bin/env perl,"
> 
> somewhere (and probably something more hacky to only catch the first line)?

And it also needs to either change perl -w to Use::Warnings or so, or 
just drop that out.  And hope that everything that might use it is a 
foo.pl.in.  If it is, we could add a mangle_perl hook before 
do_configure after do_patch, inside of autotools.bbclass (or just make 
it happen in there?).

-- 
Tom Rini
Mentor Graphics Corporation



      reply	other threads:[~2010-08-12 19:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-27 23:45 [RFC] Disable packaged-staging for perl-native Tom Rini
2010-07-28  7:09 ` Koen Kooi
2010-07-28  7:28 ` Roman I Khimov
2010-07-28 15:45   ` Tom Rini
2010-08-12 17:12     ` Tom Rini
2010-08-12 17:29       ` Roman I Khimov
2010-08-12 19:00         ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C6444DF.40206@mentor.com \
    --to=tom_rini@mentor.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.