All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joonyoung Shim <jy0922.shim@samsung.com>
To: Seungwhan Youn <claude.youn@gmail.com>
Cc: alsa-devel@alsa-project.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Seungwhan Youn <sw.youn@samsung.com>,
	Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 1/5] ASoC: Remove -dai suffix from Samsung DAI devices
Date: Fri, 13 Aug 2010 15:14:51 +0900	[thread overview]
Message-ID: <4C64E2DB.5020602@samsung.com> (raw)
In-Reply-To: <AANLkTinKaUygGxZc+pBg_LdOpvWcEErcf8yCvqfid5CU@mail.gmail.com>

Hi,

On 2010-08-13 오후 2:12, Seungwhan Youn wrote:
> Hi Mark,
>
> On Thu, Aug 12, 2010 at 7:02 PM, Mark Brown
> <broonie@opensource.wolfsonmicro.com>  wrote:
>> The IP blocks are all fixed function audio controllers so there's no
>> need to dedupe against other usages and the corresponding arch/arm
>> updates got missed anyway so revert to the original names for the
>> drivers.
>>
>> Signed-off-by: Mark Brown<broonie@opensource.wolfsonmicro.com>
>> ---
>>   sound/soc/s3c24xx/aquila_wm8994.c              |    2 +-
>>   sound/soc/s3c24xx/goni_wm8994.c                |    2 +-
>>   sound/soc/s3c24xx/jive_wm8750.c                |    2 +-
>>   sound/soc/s3c24xx/ln2440sbc_alc650.c           |    2 +-
>>   sound/soc/s3c24xx/neo1973_gta02_wm8753.c       |    2 +-
>>   sound/soc/s3c24xx/neo1973_wm8753.c             |    2 +-
>>   sound/soc/s3c24xx/s3c2412-i2s.c                |    2 +-
>>   sound/soc/s3c24xx/s3c24xx-i2s.c                |    2 +-
>>   sound/soc/s3c24xx/s3c24xx_simtec_hermes.c      |    2 +-
>>   sound/soc/s3c24xx/s3c24xx_simtec_tlv320aic23.c |    2 +-
>>   sound/soc/s3c24xx/s3c24xx_uda134x.c            |    2 +-
>>   sound/soc/s3c24xx/s3c64xx-i2s-v4.c             |    2 +-
>>   sound/soc/s3c24xx/s3c64xx-i2s.c                |    2 +-
>>   sound/soc/s3c24xx/smartq_wm8987.c              |    2 +-
>>   sound/soc/s3c24xx/smdk64xx_wm8580.c            |    4 ++--
>>   15 files changed, 16 insertions(+), 16 deletions(-)
>>
>> diff --git a/sound/soc/s3c24xx/aquila_wm8994.c b/sound/soc/s3c24xx/aquila_wm8994.c
>> index 44b06e9..235d197 100644
>> --- a/sound/soc/s3c24xx/aquila_wm8994.c
>> +++ b/sound/soc/s3c24xx/aquila_wm8994.c
>> @@ -233,7 +233,7 @@ static struct snd_soc_dai_link aquila_dai[] = {
>>   {
>>         .name = "WM8994",
>>         .stream_name = "WM8994 HiFi",
>> -       .cpu_dai_name = "s3c64xx-i2s-v4-dai",
>> +       .cpu_dai_name = "s3c64xx-i2s-v4",
>
> This aquila board also use I2Sv4 from 's3c64xx-i2s-v4.c', so I think
> it'll not work if cpu_dai_name is 's3c64xx-i2s-v4' not
> 's3c64xx-iis-v4'.

It confused me a little to use two names "iis" and "i2s". Can we unify 
to one?
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2010-08-13  6:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-12 10:02 [PATCH 1/5] ASoC: Remove -dai suffix from Samsung DAI devices Mark Brown
2010-08-12 10:02 ` [PATCH 2/5] ASoC: Add MODULE_ALIAS to Samsung DAI drivers Mark Brown
2010-08-12 10:02 ` [PATCH 3/5] S3C64XX: Add missing S3C64XX DMA device Mark Brown
2010-08-12 10:02 ` [PATCH 4/5] SMDK6410: Register audio " Mark Brown
2010-08-12 10:02 ` [PATCH 5/5] ASoC: Fix indentiation in S3C DMA driver Mark Brown
2010-08-13  5:38   ` Jassi Brar
2010-08-13  6:20     ` Seungwhan Youn
2010-08-13  8:44     ` Mark Brown
2010-08-13  5:12 ` [PATCH 1/5] ASoC: Remove -dai suffix from Samsung DAI devices Seungwhan Youn
2010-08-13  6:14   ` Joonyoung Shim [this message]
2010-08-13  8:59     ` Mark Brown
2010-08-13  9:29       ` Joonyoung Shim
2010-08-13 11:20       ` Seungwhan Youn
2010-08-13 12:29         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C64E2DB.5020602@samsung.com \
    --to=jy0922.shim@samsung.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=claude.youn@gmail.com \
    --cc=cw00.choi@samsung.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=lrg@slimlogic.co.uk \
    --cc=sw.youn@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.