From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=46723 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OjzL7-0008RS-Nd for qemu-devel@nongnu.org; Fri, 13 Aug 2010 14:50:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OjzL6-00024O-Cz for qemu-devel@nongnu.org; Fri, 13 Aug 2010 14:50:49 -0400 Received: from mail-yw0-f45.google.com ([209.85.213.45]:58294) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OjzL6-00023z-9e for qemu-devel@nongnu.org; Fri, 13 Aug 2010 14:50:48 -0400 Received: by ywt2 with SMTP id 2so1154064ywt.4 for ; Fri, 13 Aug 2010 11:50:46 -0700 (PDT) Message-ID: <4C6593FB.2050008@codemonkey.ws> Date: Fri, 13 Aug 2010 13:50:35 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1281622202-3453-3-git-send-email-stefano.stabellini@eu.citrix.com> In-Reply-To: <1281622202-3453-3-git-send-email-stefano.stabellini@eu.citrix.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 03/15] xen: Add a new target to qemu: target-xen List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: stefano.stabellini@eu.citrix.com Cc: Anthony.Perard@citrix.com, xen-devel@lists.xensource.com, qemu-devel@nongnu.org On 08/12/2010 09:09 AM, stefano.stabellini@eu.citrix.com wrote: > From: Anthony PERARD > > This patch adds a new Xen device model target to Qemu, called > target-xen. > A xen specific target is definitely the wrong approach. I understand the desire to avoid the TCG code. We would like to (optionally) do the same in KVM. The right way to do this though is to make it possible to build without TCG by wrapping the common interfaces in a function pointer table. > diff --git a/target-xen/exec-dm.c b/target-xen/exec-dm.c > new file mode 100644 > index 0000000..3d64695 > --- /dev/null > +++ b/target-xen/exec-dm.c > This takes a non-target specific file and makes it target specific. This is not a reasonable approach. What's the issue with the existing exec.c? Regards, Anthony Liguori From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 03/15] xen: Add a new target to qemu: target-xen Date: Fri, 13 Aug 2010 13:50:35 -0500 Message-ID: <4C6593FB.2050008@codemonkey.ws> References: <1281622202-3453-3-git-send-email-stefano.stabellini@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1281622202-3453-3-git-send-email-stefano.stabellini@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: stefano.stabellini@eu.citrix.com Cc: Anthony.Perard@citrix.com, xen-devel@lists.xensource.com, qemu-devel@nongnu.org List-Id: xen-devel@lists.xenproject.org On 08/12/2010 09:09 AM, stefano.stabellini@eu.citrix.com wrote: > From: Anthony PERARD > > This patch adds a new Xen device model target to Qemu, called > target-xen. > A xen specific target is definitely the wrong approach. I understand the desire to avoid the TCG code. We would like to (optionally) do the same in KVM. The right way to do this though is to make it possible to build without TCG by wrapping the common interfaces in a function pointer table. > diff --git a/target-xen/exec-dm.c b/target-xen/exec-dm.c > new file mode 100644 > index 0000000..3d64695 > --- /dev/null > +++ b/target-xen/exec-dm.c > This takes a non-target specific file and makes it target specific. This is not a reasonable approach. What's the issue with the existing exec.c? Regards, Anthony Liguori