From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] Fix bug for vcpu hotplug
Date: Sun, 15 Aug 2010 15:06:28 +0300
Message-ID: <4C67D844.5060306@redhat.com>
References: <BC00F5384FCFC9499AF06F92E8B78A9E0B0007F9DC@shsmsx502.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"seabios@seabios.org" <seabios@seabios.org>,
	"Kevin O'Connor" <kevin@koconnor.net>,
	"Jiang, Yunhong" <yunhong.jiang@intel.com>,
	"Li, Xin" <xin.li@intel.com>,
	"Zheng, Shaohui" <shaohui.zheng@intel.com>,
	"You, Yongkang" <yongkang.you@intel.com>
To: "Liu, Jinsong" <jinsong.liu@intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:44545 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1758483Ab0HOQNR (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 15 Aug 2010 12:13:17 -0400
In-Reply-To: <BC00F5384FCFC9499AF06F92E8B78A9E0B0007F9DC@shsmsx502.ccr.corp.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

  On 08/06/2010 06:36 AM, Liu, Jinsong wrote:
> Recently seabios implement vcpu hotplug infrastructure.
> During test, we found qemu-kvm has a bug result in guestos shutdown when vcpu hotadd.
> This patch is to fix the bug, mark bus->allow_hotplug as 1 after qdev_hotplug init done.

Please copy qemu-devel on qemu patches.

> @@ -117,6 +117,9 @@ DeviceState *qdev_create(BusState *bus, const char *name)
>           hw_error("Unknown device '%s' for bus '%s'\n", name, bus->info->name);
>       }
>
> +    if (qdev_hotplug)
> +        bus->allow_hotplug = 1;
> +
>       return qdev_create_from_info(bus, info);
>   }

Doesn't seem right - this will set allow_hotplug on all busses.

It needs to be set only on the system bus (hw/sysbus.c).

-- 
error compiling committee.c: too many arguments to function