From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: Mohammed Gamal <m.gamal005@gmail.com>,
mtosatti@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH 2/2] x86: Bail out on unemulated instructions
Date: Sun, 15 Aug 2010 19:17:10 +0300 [thread overview]
Message-ID: <4C681306.6000400@redhat.com> (raw)
In-Reply-To: <20100815161157.GA25987@redhat.com>
On 08/15/2010 07:11 PM, Gleb Natapov wrote:
>
>> Neither are possible. We can have one cpu in big real mode and
>> others in paged mode, so even in real mode we cannot rule out a
>> spurious page fault due to shadow write protection.
>>
> Correct, just checking X86EMUL_MODE_REAL is not enough due to smp, but
> why checking for big real mode will not work? If instruction can't be
> emulated while vcpu is in big real mode returning to vcpu is not an option,
> so kvm will fail anyway.
Right. I guess we can have an emulation_reason variable which explains
why we are emulating (unvirtualizable state, mmu page fault, mmio page
fault, unvirtualizable instruction) and decide accordingly. But it's a
lot of work.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-08-15 16:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-14 15:51 [PATCH 1/2] x86 emulator: Fix emulator return values Mohammed Gamal
2010-08-14 15:51 ` [PATCH 2/2] x86: Bail out on unemulated instructions Mohammed Gamal
2010-08-15 7:32 ` Gleb Natapov
2010-08-15 12:40 ` Mohammed Gamal
2010-08-15 12:41 ` Gleb Natapov
2010-08-15 12:43 ` Mohammed Gamal
2010-08-15 12:49 ` Gleb Natapov
2010-08-15 15:58 ` Avi Kivity
2010-08-15 16:11 ` Gleb Natapov
2010-08-15 16:17 ` Avi Kivity [this message]
2010-08-15 15:40 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C681306.6000400@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=m.gamal005@gmail.com \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.