Re: [PATCH][RFC] ARM: mach-shmobile: AP4EVB: use gpio-leds for leds.

[Arnd Hannemann <arnd@arndnet.de>]

Hi Paul,

Am 16.08.2010 06:23, schrieb Paul Mundt:
> On Sat, Aug 14, 2010 at 09:45:21PM +0200, Arnd Hannemann wrote:
>> This allows control of the leds on the AP4EVB board by kernel
>> events (triggers) like mmc0/mmc1. In userland, the leds won't be
>> available anymore over /sys/class/gpio but via /sys/class/leds.
>>
>> Signed-off-by: Arnd Hannemann <arnd@arndnet.de>
>
> A few minor nits. For starters, your editor has added trailing
> whitespace all over the place, so please run future patches through
> checkpatch for basic sanity checks first.

Ok, will do and resend.

>> +static struct gpio_led ap4evb_leds[] = {
> [snip]
>> +}; + +static struct gpio_led_platform_data ap4evb_leds_pdata = { +
>> .num_leds = ARRAY_SIZE(ap4evb_leds), +    .leds = &ap4evb_leds, +}; +
> Here you obviously want .leds = ap4evb_leds. Has this been tested?

Yes, this has been tested, I wonder why it worked...

> I'll apply it with those fixes, since it's a reasonable direction to
> go.

Thanks,
Arnd