From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Sandeen Subject: Re: [PATCH 4/4] Ext4 check for negative err from sb_issue_discard Date: Mon, 16 Aug 2010 11:57:29 -0500 Message-ID: <4C696DF9.4000209@redhat.com> References: <1280935813-4478-1-git-send-email-lczerner@redhat.com> <1280935813-4478-4-git-send-email-lczerner@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-ext4@vger.kernel.org, jmoyer@redhat.com, rwheeler@redhat.com, eshishki@redhat.com, jack@suse.cz, tytso@mit.edu To: Lukas Czerner Return-path: Received: from mx1.redhat.com ([209.132.183.28]:36322 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751707Ab0HPQ5g (ORCPT ); Mon, 16 Aug 2010 12:57:36 -0400 In-Reply-To: <1280935813-4478-4-git-send-email-lczerner@redhat.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: Lukas Czerner wrote: > sb_issue_discard is returning negative error code, so check for > negative value instead of positive. > > Signed-off-by: Lukas Czerner > --- > fs/ext4/mballoc.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c > index a16a813..a8fe7f1 100644 > --- a/fs/ext4/mballoc.c > +++ b/fs/ext4/mballoc.c > @@ -2589,7 +2589,7 @@ static void release_blocks_on_commit(journal_t *journal, transaction_t *txn) > (unsigned long long)discard_block, > entry->count); > ret = sb_issue_discard(sb, discard_block, entry->count); > - if (ret == EOPNOTSUPP) { > + if (ret == -EOPNOTSUPP) { > ext4_warning(sb, > "discard not supported, disabling"); > clear_opt(EXT4_SB(sb)->s_mount_opt, DISCARD); Thanks for fixing that, Lukas. Dumb thinko on my part, too much XFS (and weird positive-error usage) on the brain ;) Ted, this can/should go in at any time, regardless of other discard changes. Thanks, -Eric