All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Brian Haley <brian.haley@hp.com>
Cc: netdev@vger.kernel.org
Subject: Re: [iproute2] iproute2:  Fix 'addr flush secondary' logic.
Date: Mon, 16 Aug 2010 10:01:01 -0700	[thread overview]
Message-ID: <4C696ECD.8080000@candelatech.com> (raw)
In-Reply-To: <4C696014.4080508@hp.com>

On 08/16/2010 08:58 AM, Brian Haley wrote:
> On 08/13/2010 03:49 PM, Ben Greear wrote:
>> Attached is an updated patch to fix some of the errors you
>> mentioned.  It also fixes a bug when '-s -s' is used:  The old
>> code modified the ifa flags, which made it not handle the check
>> for primary v/s secondary correctly in the next filter.
>
> Thanks for the update, nitpicking comments below.
>
> BTW, promote_secondaries was the reason for some of my testing
> issues as I don't usually run with that enabled.

Thanks for all the help and suggestions.  I just sent an
'official' patch with your final suggestions included.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


      reply	other threads:[~2010-08-16 17:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-11 17:19 [iproute2] iproute2: Fix 'addr flush secondary' logic Ben Greear
2010-08-11 20:41 ` Brian Haley
2010-08-11 20:53   ` Ben Greear
2010-08-11 22:48   ` Ben Greear
2010-08-12 19:00     ` Brian Haley
2010-08-12 19:10       ` Ben Greear
2010-08-13 19:49       ` Ben Greear
2010-08-16 15:58         ` Brian Haley
2010-08-16 17:01           ` Ben Greear [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C696ECD.8080000@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=brian.haley@hp.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.