All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Marlin <dmarlin@redhat.com>
To: LTP list <ltp-list@lists.sourceforge.net>
Subject: [LTP] warning when building pread01.c
Date: Mon, 16 Aug 2010 13:24:22 -0500	[thread overview]
Message-ID: <4C698256.4010804@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 527 bytes --]


Function compare_bufers in pread01.c does not expect any arguments, but 
the reference to compare_bufers passes two arguments:

     compare_bufers(write_buf, read_buf);


Within the function compare_bufers, write_buf and read_buf are accessed 
via their global definitions.  These variables are also accessed via the 
global definitions in other functions in this testcase.

Attached is a patch to remove the unnecessary arguments from the 
compare_bufers function reference.


Signed-off-by: d.marlin <dmarlin@redhat.com>



[-- Attachment #2: pread01.c.patch --]
[-- Type: text/x-patch, Size: 395 bytes --]

--- testcases/kernel/syscalls/pread/pread01.c.orig	2010-04-01 01:23:10.000000000 -0500
+++ testcases/kernel/syscalls/pread/pread01.c	2010-07-07 19:07:30.375647906 -0500
@@ -183,7 +183,7 @@
 			 * with the data written to write buffer
 			 * in the setup.
 			 */
-			compare_bufers(write_buf, read_buf);
+			compare_bufers();
 		} else {
 			tst_resm(TPASS, "calls to pread() succeeded");
 		}


[-- Attachment #3: Type: text/plain, Size: 224 bytes --]

------------------------------------------------------------------------------
This SF.net email is sponsored by 

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev 

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

                 reply	other threads:[~2010-08-16 18:24 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C698256.4010804@redhat.com \
    --to=dmarlin@redhat.com \
    --cc=ltp-list@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.