From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=52546 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ol6Gr-0002L7-CI for qemu-devel@nongnu.org; Mon, 16 Aug 2010 16:27:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Ol6Gq-0000wP-6R for qemu-devel@nongnu.org; Mon, 16 Aug 2010 16:27:01 -0400 Received: from mail-fx0-f45.google.com ([209.85.161.45]:63565) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ol6Gq-0000wI-1R for qemu-devel@nongnu.org; Mon, 16 Aug 2010 16:27:00 -0400 Received: by fxm7 with SMTP id 7so3315147fxm.4 for ; Mon, 16 Aug 2010 13:26:58 -0700 (PDT) Message-ID: <4C699F0C.5040601@gmail.com> Date: Mon, 16 Aug 2010 23:26:52 +0300 From: Janne Huttunen MIME-Version: 1.0 Subject: Re: [Qemu-devel] Unknown command 0xffffff in SVGA command FIFO References: <4C47198A.2080308@gmail.com> <12798489222610-git-send-email-> In-Reply-To: <12798489222610-git-send-email-> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: andrzej zaborowski Cc: qemu-devel@nongnu.org > I came up with this version, it kind of reverses the logic of your > patch but reuses the _items function (renamed _length), please > see if it looks ok and possibly even works. [sorry about the delay, I was out of office for a while] Yes, your version works (both on paper and in practice). I'm not quite sure I like the way it breaches the apparent abstraction of the FIFO handling routines (if you can call it that) or the way it first gives FIFO slots back to the guest but then rewinds them back. Not that either of those concerns necessarily matter much. BTW, now that I look at it, if either HW_FILL_ACCEL or HW_RECT_ACCEL is not set 'badcmd' will be called, but args won't be set (as far as I can see). Isn't that wrong? Although I think the bug was there even before your changes.