From: Michal Marek <mmarek@suse.cz>
To: "Américo Wang" <xiyou.wangcong@gmail.com>
Cc: Mike Frysinger <vapier@gentoo.org>,
linux-kbuild@vger.kernel.org,
Roman Zippel <zippel@linux-m68k.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kconfig: fix warnings in fgets/fwrite usage
Date: Tue, 17 Aug 2010 08:44:18 +0200 [thread overview]
Message-ID: <4C6A2FC2.9050908@suse.cz> (raw)
In-Reply-To: <20100817054640.GD5095@cr0.nay.redhat.com>
On 17.8.2010 07:46, Américo Wang wrote:
> On Thu, Aug 12, 2010 at 01:56:19AM -0400, Mike Frysinger wrote:
>> Add some helper functions that abort on failure, and change the fwrite
>> and fget calls to use those. This should kill off all the ugly gcc
>> warnings that some distros emit about ignoring return values due to
>> usage of warn_unused_result attributes.
>>
>> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>
> Looks good to me,
>
> Acked-by: WANG Cong <xiyou.wangcong@gmail.com>
I already merged similar patches by Jean Sacren, see commits bf5e327 and
4418a2b in kbuild-2.6.git.
Michal
next prev parent reply other threads:[~2010-08-17 6:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-12 5:56 [PATCH] kconfig: fix warnings in fgets/fwrite usage Mike Frysinger
2010-08-17 5:46 ` Américo Wang
2010-08-17 6:44 ` Michal Marek [this message]
2010-08-18 5:36 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6A2FC2.9050908@suse.cz \
--to=mmarek@suse.cz \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vapier@gentoo.org \
--cc=xiyou.wangcong@gmail.com \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.