From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masami Hiramatsu Subject: Re: [PATCH -next] optprobes: fix kconfig depends/selects Date: Wed, 18 Aug 2010 00:03:56 +0900 Message-ID: <4C6AA4DC.8090307@hitachi.com> References: <20100812122641.fe88e846.randy.dunlap@oracle.com> <4C6AA2DF.5020301@hitachi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mail9.hitachi.co.jp ([133.145.228.44]:39909 "EHLO mail9.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751261Ab0HQPEC (ORCPT ); Tue, 17 Aug 2010 11:04:02 -0400 In-Reply-To: <4C6AA2DF.5020301@hitachi.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Randy Dunlap Cc: lkml , linux-next@vger.kernel.org, Ananth N Mavinakayanahalli , Anil S Keshavamurthy , "David S. Miller" , akpm Masami Hiramatsu wrote: > Randy Dunlap wrote: >> From: Randy Dunlap >> >> KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency. >> KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL. > > Indeed, Thanks for pointing it! > > Signed-off-by: Masami Hiramatsu Oops, I meant; Acked-by: Masami Hiramatsu Sorry:( > >> warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS) >> >> Signed-off-by: Randy Dunlap >> Cc: Ananth N Mavinakayanahalli >> Cc: Anil S Keshavamurthy >> Cc: "David S. Miller" >> Cc: Masami Hiramatsu >> --- >> arch/Kconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> --- linux-next-20100810.orig/arch/Kconfig >> +++ linux-next-20100810/arch/Kconfig >> @@ -45,6 +45,8 @@ config OPTPROBES >> def_bool y >> depends on KPROBES && HAVE_OPTPROBES >> depends on !PREEMPT >> + depends on DEBUG_KERNEL >> + select KALLSYMS >> select KALLSYMS_ALL >> >> config HAVE_EFFICIENT_UNALIGNED_ACCESS > >