All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Alan Cox <alan@linux.intel.com>,
	linux-ide@vger.kernel.org, jeff@garzik.org
Subject: Re: [PATCH RFC] ata: Intel IDE-R support
Date: Tue, 17 Aug 2010 18:30:17 +0200	[thread overview]
Message-ID: <4C6AB919.7060203@kernel.org> (raw)
In-Reply-To: <20100817174257.3691ed68@lxorguk.ukuu.org.uk>

Hello,

On 08/17/2010 06:42 PM, Alan Cox wrote:
>> This looks scary to me.  Is this something documented somewhere?  It's
>> not like we can avoid adding PCI device IDs completely anyway, so I
>> would suggest just doing it good old fashioned way.
> 
> The trouble with adding all the ids is it will keep needing updates every
> chipset (and a lot of existing idents).

But we do that for some controllers anyway so it's not something new.
ata_piix already has list of all the devices it supports, so maybe
it's safe to grab all intel IDE devices from ata_generic?  ata_piix
always has higher priority than ata_generic anyway and if a device
isn't grabbed by ata_piix, we don't lose anything by grabbing it from
ata_generic.

> Is it documented ? The instructions it was written to came from the
> people who do the chips.

Yeap, that's much better, but I still think it would be better to
avoid such detection magics if possible.

Thanks.

-- 
tejun

  reply	other threads:[~2010-08-17 16:33 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-10 15:56 [PATCH RFC] ata: Intel IDE-R support Alan Cox
2010-08-10 17:12 ` Sergei Shtylyov
2010-08-10 22:23   ` Alan Cox
2010-08-17 16:19 ` Tejun Heo
2010-08-17 16:42   ` Alan Cox
2010-08-17 16:30     ` Tejun Heo [this message]
2010-08-17 17:01       ` Alan Cox
2010-08-17 16:59         ` Tejun Heo
2010-08-17 18:23           ` Alan Cox
2010-08-18  6:19             ` Tejun Heo
2010-08-18 10:03               ` Alan Cox
2010-08-18 14:10                 ` Tejun Heo
2010-08-18 15:15                   ` Alan Cox
2010-08-19  9:37                     ` Tejun Heo
2010-08-19 10:09                       ` Alan Cox
2010-08-19 11:22                         ` Tejun Heo
2010-08-19 11:35                           ` Kay Sievers
2010-08-19 11:42                             ` Tejun Heo
2010-08-19 12:24                               ` Kay Sievers
2010-08-19 12:33                                 ` Tejun Heo
2010-08-19 12:52                                   ` Kay Sievers
2010-08-19 12:54                                     ` Tejun Heo
2010-08-19 13:08                                       ` Kay Sievers
2010-08-19 13:14                                         ` Tejun Heo
2010-08-19 12:56                           ` Tejun Heo
2010-08-19 18:05                             ` Jeff Garzik
2010-08-19 11:02                       ` Tim Small

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C6AB919.7060203@kernel.org \
    --to=tj@kernel.org \
    --cc=alan@linux.intel.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.