From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, allan.stephens@windriver.com
Subject: Re: [PATCH net-next 11/14] tipc: Eliminate useless linked list initialization
Date: Wed, 18 Aug 2010 09:28:27 -0400 [thread overview]
Message-ID: <4C6BDFFB.2050008@windriver.com> (raw)
In-Reply-To: <20100817.172930.226785324.davem@davemloft.net>
On 10-08-17 08:29 PM, David Miller wrote:
> From: Paul Gortmaker<paul.gortmaker@windriver.com>
> Date: Tue, 17 Aug 2010 17:00:13 -0400
>
>> From: Allan Stephens<allan.stephens@windriver.com>
>>
>> Eliminate the initialization of the port_list field of a newly created
>> TIPC port, since the port is immediately added to TIPC's global list
>> of ports (which alters the port_list field).
>>
>> Signed-off-by: Allan Stephens<allan.stephens@windriver.com>
>> Signed-off-by: Paul Gortmaker<paul.gortmaker@windriver.com>
>
> This is not correct.
>
> INIT_LIST_HEAD() is mandatory for all new objects, since it may
> initialize debugging knobs and whatnot inside of the list_head object
> when certain debugging options are enabled.
>
> Therefore it may never be elided.
Thanks, I should have come to the same conclusion when I was looking
at that one.
P.
next prev parent reply other threads:[~2010-08-18 13:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 21:00 [PATCH 0/14 net-next] more TIPC fixes and updates Paul Gortmaker
2010-08-17 21:00 ` [PATCH net-next 01/14] tipc: Fix log buffer memory leak if initialization fails Paul Gortmaker
2010-08-17 21:00 ` [PATCH net-next 02/14] tipc: add SO_RCVLOWAT support to stream socket receive path Paul Gortmaker
2010-08-17 21:00 ` [PATCH net-next 03/14] tipc: Provide correct error code for unsupported connect() operation Paul Gortmaker
2010-08-17 21:00 ` [PATCH net-next 04/14] tipc: correct problems with misleading flags returned using poll() Paul Gortmaker
2010-08-17 21:00 ` [PATCH net-next 05/14] tipc: Check for disabled bearer when processing incoming messages Paul Gortmaker
2010-08-17 21:00 ` [PATCH net-next 06/14] tipc: Prevent crash when broadcast link cannot send to all nodes Paul Gortmaker
2010-08-17 21:00 ` [PATCH net-next 07/14] tipc: Fix premature broadcast advertisement by sending node Paul Gortmaker
2010-08-17 21:00 ` [PATCH net-next 08/14] tipc: Fix bug in broadcast link transmit statistics computation Paul Gortmaker
2010-08-17 21:00 ` [PATCH net-next 09/14] tipc: Remove per-connection sequence number logic Paul Gortmaker
2010-08-17 21:00 ` [PATCH net-next 10/14] tipc: Optimize tipc_node_has_active_links() Paul Gortmaker
2010-08-17 21:00 ` [PATCH net-next 11/14] tipc: Eliminate useless linked list initialization Paul Gortmaker
2010-08-18 0:29 ` David Miller
2010-08-18 13:28 ` Paul Gortmaker [this message]
2010-08-17 21:00 ` [PATCH net-next 12/14] tipc: Minor enhancements to name table display format Paul Gortmaker
2010-08-17 21:00 ` [PATCH net-next 13/14] tipc: Allow connect() to wait indefinitely Paul Gortmaker
2010-08-17 21:00 ` [PATCH net-next 14/14] tipc: Prevent missing name table entries when link flip-flops rapidly Paul Gortmaker
2010-08-18 0:33 ` [PATCH 0/14 net-next] more TIPC fixes and updates David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6BDFFB.2050008@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=allan.stephens@windriver.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.