Re: kmalloc issue on MIPS target

[Sergei Shtylyov <sshtylyov@mvista.com>]

Hello.

naveen yadav wrote:

> Hi Ralf,

> I understand that that I need to make kmalloc.h in my arch specific
> folder. But I could not get answer, what should be appropriate
> value of  ARCH_KMALLOC_MINALIGN  is it 32 or 128 ?

    You've been replied already that you should set it to 32.

> Thanks.

> On Wed, Aug 18, 2010 at 8:13 PM, Ralf Baechle <ralf@linux-mips.org> wrote:
>> On Wed, Aug 18, 2010 at 07:56:16PM +0530, naveen yadav wrote:
>>
>>> I will give more info.
>>>
>>> CONFIG_MIPS_L1_CACHE_SHIFT=5
>>>
>>> CONFIG_DMA_NONCOHERENT=y
>>>
>>> mips 34kc is processor
>>>
>>> and File we are using is  arch/mips/include/asm/mach-generic/kmalloc.h
>>>
>>> #ifndef __ASM_MACH_GENERIC_KMALLOC_H
>>> #define __ASM_MACH_GENERIC_KMALLOC_H
>>>
>>>
>>> #ifndef CONFIG_DMA_COHERENT
>>> /*
>>>  * Total overkill for most systems but need as a safe default.
>>>  * Set this one if any device in the system might do non-coherent DMA.
>>>  */
>>> #define ARCH_KMALLOC_MINALIGN   128
>>> #endif
>>>
>>> #endif /* __ASM_MACH_GENERIC_KMALLOC_H */

>>> So shall we make value ARCH_KMALLOC_MINALIGN   from 128 to 32. is
>>> there any problem ?

>> No, that's just what you should do.  You do that by putting a file
>> that defines ARCH_KMALLOC_MINALIGN into your platforms's
>> arch/mips/include/asm/mach-<yourplatform>/kmalloc.h just like the ip32
>> file from your original posting.

>>  Ralf

WBR, Sergei