From: Albert ARIBAUD <albert.aribaud@free.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Align linebuf to avoid misaligned aliases of it
Date: Wed, 18 Aug 2010 19:46:10 +0200 [thread overview]
Message-ID: <4C6C1C62.9020609@free.fr> (raw)
In-Reply-To: <AANLkTi=1wwq5KWZg960701xeF9XJLDaLmHmtQh0xgz6J@mail.gmail.com>
Le 18/08/2010 18:46, Mike Frysinger a ?crit :
> On Wed, Aug 18, 2010 at 8:49 AM, Albert ARIBAUD wrote:
>> Le 14/08/2010 19:42, Mike Frysinger a ?crit :
>>> On Sat, Aug 14, 2010 at 4:33 AM, Albert ARIBAUD wrote:
>>>> Le 14/08/2010 10:25, Mike Frysinger a ?crit :
>>>>>> int print_buffer (ulong addr, void* data, uint width, uint count, uint
>>>>>> linelen)
>>>>>> {
>>>>>> - uint8_t linebuf[MAX_LINE_LENGTH_BYTES + 1];
>>>>>> + uint8_t linebuf[MAX_LINE_LENGTH_BYTES + 1]
>>>>>> + __attribute__((__aligned__(sizeof(uint32_t))));
>>>>>
>>>>> __aligned(sizeof(uint32_t))
>>>>
>>>> I based the __aligned__ on what's in post/cpu/ppc4xx/cache.c. What is the
>>>> difference between __aligned and __aligned__?
>>>
>>> i dont mean "__attribute__((__aligned(sizeof(uint32_t))))", i mean
>>> "__aligned(sizeof(uint32_t))". the linux compiler headers take care
>>> of expanding it to an attribute.
>>
>> The __aligned(...) syntax fails to compile with the ELDK 4.2 arm toolchain.
>
> you need to include linux/compiler.h first ... but i would have
> thought this be a header already included globally. maybe that's a
> new topic to start.
> -mike
I don't understand why I should introduce a dependency on linux. What is
the benefit?
Amicalement,
--
Albert.
next prev parent reply other threads:[~2010-08-18 17:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-14 8:11 [U-Boot] [PATCH] Align linebuf to avoid misaligned aliases of it Albert Aribaud
2010-08-14 8:25 ` Mike Frysinger
2010-08-14 8:33 ` Albert ARIBAUD
2010-08-14 17:42 ` Mike Frysinger
2010-08-18 12:49 ` Albert ARIBAUD
2010-08-18 16:46 ` Mike Frysinger
2010-08-18 17:46 ` Albert ARIBAUD [this message]
2010-08-18 17:54 ` Mike Frysinger
2010-08-18 20:36 ` Albert ARIBAUD
2010-08-19 5:58 ` Mike Frysinger
2010-08-20 6:48 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6C1C62.9020609@free.fr \
--to=albert.aribaud@free.fr \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.