From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Masroor Vettuparambil <Masroor.Vettuparambil@exar.com>,
M A Young <m.a.young@durham.ac.uk>
Subject: Re: xen build error on gcc v4.5.0
Date: Wed, 18 Aug 2010 16:07:30 -0700 [thread overview]
Message-ID: <4C6C67B2.60508@goop.org> (raw)
In-Reply-To: <C891F940.4E10%keir.fraser@eu.citrix.com>
On 08/18/2010 12:55 PM, Keir Fraser wrote:
> On 18/08/2010 20:44, "M A Young" <m.a.young@durham.ac.uk> wrote:
>
>> On Wed, 18 Aug 2010, Jeremy Fitzhardinge wrote:
>>> Looks like a gcc bug. Older gccs can compute __RING_SIZE() as a
>>> compile-time constant, but gcc 4.5.0 apparently isn't doing that. It
>>> is, admittedly, a very complex expression, but gcc shouldn't regress
>>> like this. I'm not sure how to work around it.
>> One option is to use __CONST_RING_SIZE instead of __RING_SIZE if that is
>> available. I had a similar problem compiling xen with gcc 4.5 where this
>> worked.
> Yes that is exactly why Jan Beulich introduced __CONST_RING_SIZE, in
> xen-unstable:20975. Should be a simple patch to pv_ops netfront/back drivers
> to make use of it.
Ah, OK. I'll bring it across and sprinkle it around.
J
prev parent reply other threads:[~2010-08-18 23:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 10:24 xen build error on gcc v4.5.0 Masroor Vettuparambil
2010-08-18 18:12 ` Jeremy Fitzhardinge
2010-08-18 19:44 ` M A Young
2010-08-18 19:55 ` Keir Fraser
2010-08-18 23:07 ` Jeremy Fitzhardinge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6C67B2.60508@goop.org \
--to=jeremy@goop.org \
--cc=Masroor.Vettuparambil@exar.com \
--cc=keir.fraser@eu.citrix.com \
--cc=m.a.young@durham.ac.uk \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.