From: Ike Panhc <ike.pan@canonical.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
Thomas Renninger <trenn@suse.de>, Alan Cox <alan@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Corentin Chary <corentincj@iksaif.net>,
David Woodhouse <David.Woodhouse@intel.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
Len Brown <len.brown@intel.com>
Subject: Re: [PATCH 3/8] ideapad: make sure we bind on the correct device
Date: Thu, 19 Aug 2010 10:51:34 +0800 [thread overview]
Message-ID: <4C6C9C36.7080904@canonical.com> (raw)
In-Reply-To: <20100818132722.GA12709@srcf.ucam.org>
On 08/18/2010 09:27 PM, Matthew Garrett wrote:
> On Wed, Aug 18, 2010 at 04:37:33PM +0800, Ike Panhc wrote:
>> By reading from method _STA and _CFG to make sure we bind on the correct
>> VPC2004 device.
>
> I know some other drivers check _STA themselves, but it's unnecessary -
> if _STA didn't evaluate appropriately, the bus driver won't create the
> pnp object and there won't be anything for you to bind to in the first
> place.
>
yes, you are right. when add, acpi_bus will check for it and tell if the
device exist or not from its bits.
next prev parent reply other threads:[~2010-08-19 2:51 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 8:36 [PATCH 0/8] [Resend] ideapad: using EC command to control rf/camera power Ike Panhc
2010-08-18 8:36 ` [PATCH 1/8] ideapad: add ACPI helpers Ike Panhc
2010-08-18 8:37 ` [PATCH 2/8] ideapad: check VPC bit before sync rfkill hw status Ike Panhc
2010-08-18 8:37 ` [PATCH 3/8] ideapad: make sure we bind on the correct device Ike Panhc
2010-08-18 13:27 ` Matthew Garrett
2010-08-19 2:51 ` Ike Panhc [this message]
2010-08-18 8:38 ` [PATCH 4/8] ideapad: use return value of _CFG to tell if device exist or not Ike Panhc
2010-08-18 8:38 ` [PATCH 5/8] ideapad: use EC command to control camera Ike Panhc
2010-08-18 8:42 ` Oliver Neukum
2010-08-18 8:51 ` Ike Panhc
2010-08-18 8:38 ` [PATCH 6/8] ideapad: rewrite the hw rfkill notify Ike Panhc
2010-08-18 8:38 ` [PATCH 7/8] ideapad: rewrite the sw rfkill set Ike Panhc
2010-08-18 8:38 ` [PATCH 8/8] ideapad: Change the driver name to ideapad_laptop Ike Panhc
2010-08-18 8:38 ` Ike Panhc
2010-08-25 20:56 ` Len Brown
2010-08-26 5:43 ` Corentin Chary
2010-08-26 5:43 ` Corentin Chary
2010-08-26 6:16 ` Ike Panhc
2010-08-26 7:43 ` Corentin Chary
2010-08-26 7:43 ` Corentin Chary
2010-09-01 11:55 ` Ike Panhc
2010-08-18 10:35 ` [PATCH 0/8] [Resend] ideapad: using EC command to control rf/camera power David Woodhouse
2010-08-18 13:04 ` Ike Panhc
2010-08-18 15:51 ` Mario 'BitKoenig' Holbe
2010-08-19 3:21 ` Ike Panhc
2010-08-19 3:21 ` Ike Panhc
2010-08-19 13:28 ` David Woodhouse
2010-08-19 19:31 ` Mario 'BitKoenig' Holbe
2010-08-20 7:01 ` Ike Panhc
2010-08-20 7:01 ` Ike Panhc
2010-08-20 9:08 ` Mario 'BitKoenig' Holbe
2010-08-23 8:22 ` Ike Panhc
2010-08-23 8:22 ` Ike Panhc
2010-08-25 11:59 ` Ike Panhc
2010-08-25 11:59 ` Ike Panhc
2010-08-25 11:59 ` Ike Panhc
2010-08-30 18:19 ` Mario 'BitKoenig' Holbe
2010-09-01 11:49 ` Ike Panhc
2010-09-01 11:49 ` Ike Panhc
2010-09-01 19:56 ` Mario 'BitKoenig' Holbe
2010-09-03 9:06 ` Ike Panhc
2010-09-03 9:06 ` Ike Panhc
2010-09-03 9:06 ` Ike Panhc
2010-09-09 18:17 ` Mario 'BitKoenig' Holbe
2010-09-10 6:44 ` Ike Panhc
2010-09-10 6:44 ` Ike Panhc
2010-09-10 6:44 ` Ike Panhc
2010-09-10 7:11 ` Mario 'BitKoenig' Holbe
2010-09-15 10:13 ` Ike Panhc
2010-09-15 10:13 ` Ike Panhc
2010-09-15 10:13 ` Ike Panhc
2010-09-15 11:48 ` Mario 'BitKoenig' Holbe
2010-09-15 12:39 ` Ike Panhc
2010-09-15 12:39 ` Ike Panhc
2010-09-16 11:59 ` Ike Panhc
2010-09-21 13:47 ` Mario 'BitKoenig' Holbe
2010-09-01 11:49 ` Ike Panhc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6C9C36.7080904@canonical.com \
--to=ike.pan@canonical.com \
--cc=David.Woodhouse@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=corentincj@iksaif.net \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.