[Qemu-devel] Re: [PATCH] balloon: Don't try fetching info if machine is stopped

[Paolo Bonzini <pbonzini@redhat.com>]

On 08/19/2010 06:14 AM, Amit Shah wrote:
> +    get_cached_data = 0;
> +    if (!vm_running) {
> +        get_cached_data = 1;
> +    }

     get_cached_data = !vm_running;

Alternatively, see below...

> +    ret = qemu_balloon_status(cb, opaque, get_cached_data);
>       if (!ret) {

Piggybacking on the existing coding style thread, here

     ret = qemu_balloon_status(cb, opaque, !vm_running);

would be quite hard to read indeed.  Maybe we can use something like this:

     ret = qemu_balloon_status(cb, opaque,
			      /*get_cached_data=*/ !vm_running);

?

Paolo