From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>,
qemu-devel <qemu-devel@nongnu.org>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules
Date: Thu, 19 Aug 2010 09:58:14 +0200 [thread overview]
Message-ID: <4C6CE416.1050902@redhat.com> (raw)
In-Reply-To: <4C6C0E4D.6040607@redhat.com>
On 08/18/10 18:46, Avi Kivity wrote:
> On 08/17/2010 10:15 PM, Jes Sorensen wrote:
>>
>>> I strongly disagree. The use of "bool", even if you ignore stdbool.h
>>> and do "typedef int bool", is valuable documentation in the code.
>> I guess we have to agree to disagree then. IMHO it just masks the real
>> type and you end up with cases where people pass it back and forth
>> randomly.
>
> In C99, bool is a real type.
Kinda real, I would qualify it more as a pseudo type. It doesn't map to
any register size or even instruction actions. Most processors, at least
the ones I have programmed, tend to treat it as zero == false,
everything else == true. For structure packing it's ugly.
Jes
next prev parent reply other threads:[~2010-08-19 8:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-12 17:50 [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules Blue Swirl
2010-08-13 19:37 ` [Qemu-devel] " Blue Swirl
2010-08-17 8:09 ` [Qemu-devel] " Jes Sorensen
2010-08-17 17:56 ` Blue Swirl
2010-08-17 18:55 ` malc
2010-08-17 19:23 ` Jes Sorensen
2010-08-17 19:24 ` malc
2010-08-17 19:43 ` Jes Sorensen
2010-08-17 20:29 ` Anthony Liguori
2010-08-17 20:33 ` malc
2010-08-17 18:39 ` Richard Henderson
2010-08-17 19:15 ` Jes Sorensen
2010-08-18 16:46 ` Avi Kivity
2010-08-19 7:58 ` Jes Sorensen [this message]
2010-08-19 8:10 ` Avi Kivity
2010-08-19 8:17 ` Jes Sorensen
2010-08-19 12:24 ` Avi Kivity
2010-08-19 12:52 ` malc
2010-08-19 12:59 ` Avi Kivity
2010-08-18 8:35 ` [Qemu-devel] " Paolo Bonzini
2010-08-18 8:58 ` Jes Sorensen
2010-08-18 10:30 ` Kevin Wolf
2010-08-18 13:57 ` Paolo Bonzini
2010-08-18 16:55 ` Avi Kivity
2010-08-19 7:51 ` Paolo Bonzini
2010-08-19 8:12 ` Avi Kivity
2010-08-18 16:44 ` [Qemu-devel] " Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6CE416.1050902@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.